Skip to content

NUMA balancing segmentation fault fixes and misc followups v3

Mel Gorman linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 28 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18mm: numa: Serialise parallel get_user_page against THP migrationarch/x86/mm/gup.c mm/huge_memory.c mm/migrate.c+60 -151 reply
2/18mm: numa: Call MMU notifiers on THP migrationmm/migrate.c+14 -81 reply
3/18mm: Clear pmd_numa before invalidatingmm/pgtable-generic.c+3 -01 reply
4/18mm: numa: Do not clear PMD during PTE update scanmm/huge_memory.c+1 -11 reply
5/18mm: numa: Do not clear PTE for pte_numa updatemm/mprotect.c+6 -21 reply
6/18mm: numa: Ensure anon_vma is locked to prevent parallel THP splitsmm/huge_memory.c+7 -01 reply
7/18mm: numa: Avoid unnecessary work on the failure pathmm/migrate.c+3 -11 reply
8/18sched: numa: Skip inaccessible VMAskernel/sched/fair.c+7 -01 reply
9/18mm: numa: Clear numa hinting information on mprotectmm/huge_memory.c mm/mprotect.c+4 -01 reply
10/18mm: numa: Avoid unnecessary disruption of NUMA hinting during migrationinclude/linux/migrate.h mm/huge_memory.c mm/migrate.c+37 -61 reply
11/18mm: fix TLB flush race between migration, and change_protection_rangearch/sparc/include/asm/pgtable_64.h arch/x86/include/asm/pgtable.h include/asm-generic/pgtable.h +5 more+69 -74 replies
12/18mm: numa: Defer TLB flush for THP migration as long as possiblemm/huge_memory.c mm/migrate.c+6 -71 reply
13/18mm: numa: Make NUMA-migrate related functions staticmm/migrate.c+3 -26 replies
14/18mm: numa: Limit scope of lock for NUMA migrate rate limitinginclude/linux/mmzone.h mm/migrate.c+13 -131 reply
15/18mm: numa: Trace tasks that fail migration due to rate limitinginclude/trace/events/migrate.h mm/migrate.c+30 -11 reply
16/18mm: numa: Do not automatically migrate KSM pagesmm/mprotect.c+2 -11 reply
17/18sched: Tracepoint task movementinclude/trace/events/sched.h kernel/sched/fair.c+37 -03 replies
18/18sched: Add tracepoints related to NUMA task migrationinclude/trace/events/sched.h kernel/sched/core.c kernel/sched/fair.c+69 -71 reply

Reviews trailers per patch

15 of 18 patches have a Reviewed-by or Acked-by.

PatchRik van Riel
1/18R-b
2/18R-b
3/18R-b
4/18R-b
5/18R-b
6/18R-b
7/18R-b
8/18R-b
9/18R-b
10/18R-b
11/18
12/18
13/18R-b
14/18R-b
15/18R-b
16/18R-b
17/18
18/18R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/18] NUMA balancing segmentation fault fixes and misc followups v3

Alex Thorlton reported segementation faults when NUMA balancing is enabled on large machines. There is no obvious explanation from the console what the problem but similar problems have been observed by Rik van Riel and myself if migration was aggressive enough. Alex, this series is against 3.13-rc2, a verification that the fix addresses your problem would be appreciated.

This series starts with a range of patches aimed at addressing the segmentation fault problem while offsetting some of the cost to avoid badly regressing performance in -stable. Those that are cc'd to stable (patches 1-12) should be merged ASAP. The rest of the series is relatively minor stuff that fell out during the course of development that is ok to wait for the next merge window but should help with the continued development of NUMA balancing.

 arch/sparc/include/asm/pgtable_64.h |   4 +-
 arch/x86/include/asm/pgtable.h      |  11 +++-
 arch/x86/mm/gup.c                   |  13 +++++
 include/asm-generic/pgtable.h       |   2 +-
 include/linux/migrate.h             |   9 ++++
 include/linux/mm_types.h            |  44 +++++++++++++++
 include/linux/mmzone.h              |   5 +-
 include/trace/events/migrate.h      |  26 +++++++++
 include/trace/events/sched.h        |  93 ++++++++++++++++++++++++++++++++
 kernel/fork.c                       |   1 +
 kernel/sched/core.c                 |   2 +
 kernel/sched/fair.c                 |  15 +++++-
 mm/huge_memory.c                    |  45 ++++++++++++----
 mm/migrate.c                        | 103 ++++++++++++++++++++++++++++--------
 mm/mprotect.c                       |  15 ++++--
 mm/pgtable-generic.c                |   8 ++-
 16 files changed, 348 insertions(+), 48 deletions(-)
Signature · 1 line
1.8.4