Skip to content

RFC Couple of timekeeping fixes

John Stultz lkml stable xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3timekeeping: Fix lost updates to tai adjustmentkernel/time/timekeeping.c+2 -10 replies
2/3timekeeping: Fix missing timekeeping_update in suspend pathkernel/time/timekeeping.c+2 -00 replies
3/3timekeeping: Fix potential lost pv notification of time changekernel/time/timekeeping.c+5 -54 replies
3/3timekeeping: Fix potential lost pv notification of time changekernel/time/timekeeping.c+5 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC][PATCH 0/3] Couple of timekeeping fixes

I was looking into the lockdep splat reported by Sasha yesterday and came across a few issues (unfortunately not related) in the timekeeping code.

The first two are issues related to not updating the shadow timekeeper after making changes to the timekeeper structure. This means those updates could be lost the next time we do update_wall_time(), since update_wall_time assumes the shadow_timekeeper is current as well.

The last change is an obvious issue that I should have caught in review, but where we handle notifying the pvclock code if time was set, there's one case in logarithmic_accumulation where we just don't pass that flag down.

Of the three patches, the first is really the most critical. I'm thinking of pushing that one into 3.13, and immediately back to 3.12-stable and 3.10-stable. Then leaving the last two for 3.14, and pushing back to 3.13/10-stable once those changes are merged.

I'm still running some tests on these, but I wanted to send them out as RFCs to get some extra review and thoughts before I send them out for real.

thanks
-john

Cc Thomas Gleixner <[email protected]>
Cc Prarit Bhargava <[email protected]>
Cc Richard Cochran <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc David Vrabel <[email protected]>

John Stultz (3):
timekeeping: Fix lost updates to tai adjustment
timekeeping: Fix missing timekeeping_update in suspend path
timekeeping: Fix potential lost pv notification of time change

 kernel/time/timekeeping.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)
Signature · 1 line
1.8.3.2