Skip to content

Use regmap+devm+DT in pm8xxx input drivers

Stephen Boyd linux-arm-kernel linux-arm-msm linux-devicetree linux-input lkml 5 versions – Applied

Status from this message: Applied all (and folded DT binding patches into respective driver

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest9 patches 3 repliesApplied
  2. v49 patches 7 repliesSuperseded
  3. v39 patches 9 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v210 patches10 repliesSuperseded
v17 patches10 repliesSuperseded

Changes in v5 from the cover letter

* Added reg property to bindings
* Added linux,* properties to keypad binding

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/9Input: pmic8xxx-keypad - Fix build by removing gpio configurationdrivers/input/keyboard/pmic8xxx-keypad.c+0 -580 replies
2/9Input: pmic8xxx-keypad - Migrate to devm_* APIsdrivers/input/keyboard/pmic8xxx-keypad.c+17 -440 replies
3/9Input: pmic8xxx-keypad - Migrate to regmap APIsdrivers/input/keyboard/pmic8xxx-keypad.c+29 -520 replies
4/9Input: pmic8xxx-keypad - Migrate to DTdrivers/input/keyboard/pmic8xxx-keypad.c include/linux/input/pmic8xxx-keypad.h+86 -1160 replies
5/9Input: pmic8xxx-pwrkey - Migrate to DTdrivers/input/misc/pmic8xxx-pwrkey.c include/linux/input/pmic8xxx-pwrkey.h+20 -440 replies
6/9Input: pm8xxx-vibrator - Add DT match tabledrivers/input/misc/pm8xxx-vibrator.c+8 -00 replies
7/9devicetree: bindings: Document PM8921/8058 keypadsDocumentation/devicetree/bindings/input/qcom,pm8xxx-keypad.txt+89 -00 replies
8/9devicetree: bindings: Document PM8921/8058 power keysDocumentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt+46 -00 replies
9/9devicetree: bindings: Document PM8921/8058 vibratorsDocumentation/devicetree/bindings/input/qcom,pm8xxx-vib.txt+22 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 0/9] Use regmap+devm+DT in pm8xxx input drivers

These patches move the pm8xxx input drivers over to use devm_* APIs and regmap. This breaks the dependency of these drivers on the pm8xxx specific read/write calls and also simplifies the probe code a bit. Finally we add devicetree support to these drivers so they can be probed on the platforms that are supported upstream.

Changes since v4:
* Added reg property to bindings
* Added linux,* properties to keypad binding

Changes since v3:
* Dropped devm conversion patch for pwrkey
* Fixed compilation of keypad

Changes since v2:
* Rebased to v3.14-rc3

Changes since v1:
* Picked up Dmitry's version of devm for pwrkey
* Added DT bindings and parsing patches
* Dropped patches picked up by Dmitry

Stephen Boyd (9):
Input: pmic8xxx-keypad - Fix build by removing gpio configuration
Input: pmic8xxx-keypad - Migrate to devm_* APIs
Input: pmic8xxx-keypad - Migrate to regmap APIs
Input: pmic8xxx-keypad - Migrate to DT
Input: pmic8xxx-pwrkey - Migrate to DT
Input: pm8xxx-vibrator - Add DT match table
devicetree: bindings: Document PM8921/8058 keypads
devicetree: bindings: Document PM8921/8058 power keys
devicetree: bindings: Document PM8921/8058 vibrators

 .../bindings/input/qcom,pm8xxx-keypad.txt          |  89 ++++++
 .../bindings/input/qcom,pm8xxx-pwrkey.txt          |  46 +++
 .../devicetree/bindings/input/qcom,pm8xxx-vib.txt  |  22 ++
 drivers/input/keyboard/pmic8xxx-keypad.c           | 348 ++++++++-------------
 drivers/input/misc/pm8xxx-vibrator.c               |   8 +
 drivers/input/misc/pmic8xxx-pwrkey.c               |  33 +-
 include/linux/input/pmic8xxx-keypad.h              |  52 ---
 include/linux/input/pmic8xxx-pwrkey.h              |  31 --
 8 files changed, 316 insertions(+), 313 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/input/qcom,pm8xxx-keypad.txt
 create mode 100644 Documentation/devicetree/bindings/input/qcom,pm8xxx-pwrkey.txt
 create mode 100644 Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.txt
 delete mode 100644 include/linux/input/pmic8xxx-keypad.h
 delete mode 100644 include/linux/input/pmic8xxx-pwrkey.h
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation