RFC make iwlwifi RT friendly
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest8 of 10 patches 9 repliesIn review
8 of 10 patches are in this archive. The cover letter announces 10.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 3/10 | iwlwifi: pcie: re-organize the PCIe ISR codedrivers/ drivers/ drivers/ | +26 | 1 reply | |
| 4/10 | iwlwifi: pcie: move the ICT / non-ICT handling functionsdrivers/ | +162 | 0 replies | |
| 5/10 | iwlwifi: pcie: read the interrupt cause from the handlerdrivers/ | +9 | 0 replies | |
| 7/10 | iwlwifi: pcie: return inta from iwl_pcie_int_cause_{non_}ictdrivers/ | +11 | 0 replies | |
| 7/10 | iwlwifi: pcie: return inta from iwl_pcie_int_cause_{non_}ictdrivers/ | +11 | 0 replies | |
| 8/10 | iwlwifi: pcie: no need to save inta in trans_pciedrivers/ drivers/ | +7 | 0 replies | |
| 9/10 | iwlwifi: pcie: move interrupt prints to the common handlerdrivers/ | +30 | 0 replies | |
| 10/10 | iwlwifi: pcie: stop using _irqsavedrivers/ drivers/ drivers/ | +47 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC 00/10] make iwlwifi RT friendly
RT folks have raised issues with iwlwifi wrt. RT kernel some time ago. Johannes had a few patches to address this, but I had a few concerns with them. This series tries to address the RT concerns:
* we don't do anything in hard-irq context besides stopping the interrupts in the device.
* the interrupt cause is read from the irq handler and is handled there.
This allows us to avoid the usage of _irqsave all over the driver and also avoids any kind of locks in the hard-irq context. We still have some work to do with the locks in the handler. I believe the locking model can be improved there.
This patch series is split is very small patches. While this can annoy the reader - it helped me much to make sure I don't do anything wrong (well - I am still not sure) - and IMHO, it makes the review easier. For example, in patch
iwlwifi: pcie: move the ICT / non-ICT handling functions
I just copy code from place to place without changing a bit. This makes the significant diff smaller.
Emmanuel Grumbach (10):
iwlwifi: pcie: clean up ICT allocation code
iwlwifi: pcie: track interrupt mask in SW
iwlwifi: pcie: re-organize the PCIe ISR code
iwlwifi: pcie: move the ICT / non-ICT handling functions
iwlwifi: pcie: read the interrupt cause from the handler
iwlwifi: pcie: determine the interrupt type in the handler
iwlwifi: pcie: return inta from iwl_pcie_int_cause_{non_}ict
iwlwifi: pcie: no need to save inta in trans_pcie
iwlwifi: pcie: move interrupt prints to the common handler
iwlwifi: pcie: stop using _irqsave
drivers/net/wireless/iwlwifi/iwl-csr.h | 3 +- drivers/net/wireless/iwlwifi/pcie/internal.h | 9 +- drivers/net/wireless/iwlwifi/pcie/rx.c | 389 +++++++++++---------------- drivers/net/wireless/iwlwifi/pcie/trans.c | 27 +- drivers/net/wireless/iwlwifi/pcie/tx.c | 10 +- 5 files changed, 185 insertions(+), 253 deletions(-)
Signature · 1 line
1.8.3.2