Skip to content

RFC Timekeeping fixes v2

John Stultz lkml stable xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5timekeeping: Fix lost updates to tai adjustmentkernel/time/timekeeping.c+2 -10 replies
2/5timekeeping: Fix potential lost pv notification of time changekernel/time/timekeeping.c+5 -50 replies
3/5timekeeping: Avoid possible deadlock from clock_was_set_delayedkernel/time/timekeeping.c+16 -210 replies
4/5timekeeping: Fix CLOCK_TAI timer/nanosleep delayskernel/time/timekeeping.c+2 -23 replies
5/5timekeeping: Fix missing timekeeping_update in suspend pathkernel/time/timekeeping.c+2 -00 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by.

PatchSasha Levin
1/5
2/5
3/5T-b
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC][PATCH 0/5] Timekeeping fixes v2

In looking into the lockdep splat reported by Sasha this week, and came across a number of issues in the timekeeping code (some related and some not).

Since I sent out v1, I came across another problem, as well as a fix for the lockdep issue, so I wanted to resend the patches for comment.

My current thought is that the first three patches are probably urgent 3.13 items, where as the last two can probably be deferred to 3.14.

The TAI timer delay thinko is particularly embarrassing, but sine CLOCK_TAI was introduced in 3.10, its not exactly a regression, and probably doesn't yet have any users outside of my tests.

Ingo/Thomas: Let me know if you agree with the first three patches as urgent. I'd probably skip the second, but it provides the infrastructure for the lockdep solution.

Sigh. Back-porting that lockdep fix to 3.10 will be a bit of a pain, and I'll have to look to see if we need it even further back or not.

thanks
-john

Cc Thomas Gleixner <[email protected]>
Cc Prarit Bhargava <[email protected]>
Cc Richard Cochran <[email protected]>
Cc Ingo Molnar <[email protected]>

John Stultz (5):
timekeeping: Fix lost updates to tai adjustment
timekeeping: Fix potential lost pv notification of time change
timekeeping: Avoid possible deadlock from clock_was_set_delayed
timekeeping: Fix CLOCK_TAI timer/nanosleep delays
timekeeping: Fix missing timekeeping_update in suspend path

 kernel/time/timekeeping.c | 37 +++++++++++++++++++++++++++----------
 1 file changed, 27 insertions(+), 10 deletions(-)
Signature · 1 line
1.8.3.2