tools lib traceevent: Get rid of *die() calls from parse-filter.c (v2)
Status from this message: I've applied all the previous patches, thanks!
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | tools lib traceevent: Get rid of malloc_or_die() in show_error()tools/ | +15 | 0 replies | |
| 2/14 | tools lib traceevent: Get rid of die in add_filter_type()tools/ | +16 | 0 replies | |
| 3/14 | tools lib traceevent: Get rid of malloc_or_die() allocate_arg()tools/ | +40 | 0 replies | |
| 4/14 | tools lib traceevent: Get rid of malloc_or_die() in read_token()tools/ | +7 | 0 replies | |
| 5/14 | tools lib traceevent: Get rid of malloc_or_die() in find_event()tools/ tools/ | +22 | 0 replies | |
| 6/14 | tools lib traceevent: Get rid of die() in add_right()tools/ tools/ | +26 | 0 replies | |
| 7/14 | tools lib traceevent: Make add_left() return pevent_errnotools/ | +3 | 0 replies | |
| 8/14 | tools lib traceevent: Get rid of die() in reparent_op_arg()tools/ tools/ | +64 | 0 replies | |
| 9/14 | tools lib traceevent: Refactor create_arg_item()tools/ tools/ | +12 | 0 replies | |
| 10/14 | tools lib traceevent: Refactor process_filter()tools/ tools/ | +42 | 0 replies | |
| 11/14 | tools lib traceevent: Make pevent_filter_add_filter_str() return pevent_errnotools/ tools/ | +27 | 0 replies | |
| 12/14 | tools lib traceevent: Refactor pevent_filter_match() to get rid of die()tools/ tools/ | +99 | 0 replies | |
| 13/14 | tools lib traceevent: Get rid of die() in some string conversion funcitonstools/ | +36 | 8 replies | |
| 14/14 | tools lib traceevent: Introduce pevent_filter_strerror()tools/ tools/ tools/ | +61 | 0 replies |
Reviews trailers per patch
5 of 14 patches have a Reviewed-by or Acked-by.
| Patch | Steven Rostedt |
|---|---|
| 1/14 | |
| 2/14 | R-b |
| 3/14 | |
| 4/14 | R-b |
| 5/14 | R-b |
| 6/14 | R-b |
| 7/14 | |
| 8/14 | R-b |
| 9/14 | |
| 10/14 | |
| 11/14 | |
| 12/14 | |
| 13/14 | |
| 14/14 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCHSET 00/14] tools lib traceevent: Get rid of *die() calls from parse-filter.c (v2)
Hello,
This patchset tries to remove all die() calls in event filter parsing code. I changed two main functions of pevent_filter_add_filter_str() and pevent_filter_match() to return a proper error code (pevent_errno).
The actual error message might be saved in a static buffer in pevent_ filter and it can be accessed by new pevent_filter_strerror() function. The old pevent_strerror() still works for them too.
The only remaining bits are in trace-seq.c which implement print functions and I want to hear what's the best way we can handle the error case during the print.
I also put this patches on libtraceevent/die-removal-v2 branch in my tree
git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
Any comments are welcome, thanks
Namhyung
Namhyung Kim (14):
tools lib traceevent: Get rid of malloc_or_die() in show_error() tools lib traceevent: Get rid of die in add_filter_type() tools lib traceevent: Get rid of malloc_or_die() allocate_arg() tools lib traceevent: Get rid of malloc_or_die() in read_token() tools lib traceevent: Get rid of malloc_or_die() in find_event() tools lib traceevent: Get rid of die() in add_right() tools lib traceevent: Make add_left() return pevent_errno tools lib traceevent: Get rid of die() in reparent_op_arg() tools lib traceevent: Refactor create_arg_item()
tools lib traceevent: Refactor process_filter()
tools lib traceevent: Make pevent_filter_add_filter_str() return
pevent_errno
tools lib traceevent: Refactor pevent_filter_match() to get rid of
die()
tools lib traceevent: Get rid of die() in some string conversion
funcitons
tools lib traceevent: Introduce pevent_filter_strerror()
tools/lib/traceevent/event-parse.c | 17 +- tools/lib/traceevent/event-parse.h | 48 ++- tools/lib/traceevent/parse-filter.c | 615 ++++++++++++++++++++++-------------- 3 files changed, 417 insertions(+), 263 deletions(-)
Signature · 1 line
1.7.11.7