Skip to content

brcmfmac: sdio rework and msgbuf protocol changes

Arend van Spriel linux-wireless 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18brcmfmac: add missing curly braces in brcmf_fws_txstatus_suppressed()drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+3 -10 replies
2/18brcmfmac: combine bcmsdh source files into onedrivers/net/wireless/brcm80211/brcmfmac/Makefile drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c+522 -5530 replies
3/18brcmfmac: remove unnecessary function prototypesdrivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c drivers/net/wireless/brcm80211/brcmfmac/sdio_host.h+231 -2630 replies
4/18brcmfmac: remove unused struct brcmf_sdio_dev::func_cis_ptr attributedrivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c drivers/net/wireless/brcm80211/brcmfmac/sdio_host.h+6 -560 replies
5/18brcmfmac: use sdio functions to enable/disable F2drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c+14 -480 replies
6/18brcmfmac: remove brcmf_sdio_regrw_helper() from header filedrivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c drivers/net/wireless/brcm80211/brcmfmac/sdio_host.h+4 -70 replies
7/18brcmfmac: remove regs parameter from sdio probe functionsdrivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.c +2 more+11 -170 replies
8/18brcmfmac: get rid of some void pointer parametersdrivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c drivers/net/wireless/brcm80211/brcmfmac/sdio_host.h+8 -140 replies
9/18brcmfmac: remove brcmf_sdio_wdtimer_enable() functiondrivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c+2 -100 replies
10/18brcmfmac: use consistent function names in bcmsdh.cdrivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c drivers/net/wireless/brcm80211/brcmfmac/sdio_chip.c +1 more+452 -4780 replies
11/18brcmfmac: reduce function parameters in sdio send/receive callsdrivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c drivers/net/wireless/brcm80211/brcmfmac/sdio_host.h+46 -670 replies
12/18brcmfmac: Move common BCDC code in single function.drivers/net/wireless/brcm80211/brcmfmac/bcdc.c+25 -430 replies
13/18brcmfmac: Fix hex dump for FWIL.drivers/net/wireless/brcm80211/brcmfmac/fwil.c+6 -60 replies
14/18brcmfmac: Add definition of new protocol layer msgbuf.drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c drivers/net/wireless/brcm80211/brcmfmac/dhd_bus.h drivers/net/wireless/brcm80211/brcmfmac/usb.c+10 -00 replies
15/18brcmfmac: Combine protocol push hdr and bus txdata.drivers/net/wireless/brcm80211/brcmfmac/bcdc.c drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c drivers/net/wireless/brcm80211/brcmfmac/proto.c +1 more+35 -290 replies
16/18brcmfmac: use consistent function names in dhd_sdio.cdrivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c drivers/net/wireless/brcm80211/brcmfmac/sdio_host.h+178 -1890 replies
17/18brcmfmac: remove brcmf_sdio_disconnect() functiondrivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c drivers/net/wireless/brcm80211/brcmfmac/sdio_host.h+23 -320 replies
18/18brcmfmac: clarify struct brcmf_sdio_dev::func[0] referencedrivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c+16 -200 replies

Reviews trailers per patch

All 18 patches have a Reviewed-by or Acked-by.

PatchHante MeulemanFranky LinPieter-Paul GiesbertsArend Van Spriel
1/18R-b R-b
2/18R-b R-b R-b
3/18R-b R-b R-b
4/18R-b R-b R-b
5/18R-b R-b R-b
6/18R-b R-b R-b
7/18R-b R-b R-b
8/18R-b R-b R-b
9/18R-b
10/18R-b R-b R-b
11/18R-b R-b R-b
12/18R-b R-b R-b
13/18R-b R-b R-b
14/18R-b R-b R-b
15/18R-b R-b R-b
16/18R-b R-b R-b
17/18R-b R-b R-b
18/18R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 00/18] brcmfmac: sdio rework and msgbuf protocol changes

This series consists mostly of cleanup in SDIO driver code. Other changes are preparing to new firmware protocol called msgbuf, which is intended for PCIe fullmac devices.

Arend van Spriel (14):
brcmfmac: add missing curly braces in brcmf_fws_txstatus_suppressed()
brcmfmac: combine bcmsdh source files into one
brcmfmac: remove unnecessary function prototypes
brcmfmac: remove unused struct brcmf_sdio_dev::func_cis_ptr attribute
brcmfmac: use sdio functions to enable/disable F2
brcmfmac: remove brcmf_sdio_regrw_helper() from header file
brcmfmac: remove regs parameter from sdio probe functions
brcmfmac: get rid of some void pointer parameters
brcmfmac: remove brcmf_sdio_wdtimer_enable() function
brcmfmac: use consistent function names in bcmsdh.c
brcmfmac: reduce function parameters in sdio send/receive calls
brcmfmac: use consistent function names in dhd_sdio.c
brcmfmac: remove brcmf_sdio_disconnect() function
brcmfmac: clarify struct brcmf_sdio_dev::func[0] reference

Hante Meuleman (4):
brcmfmac: Move common BCDC code in single function.
brcmfmac: Fix hex dump for FWIL.
brcmfmac: Add definition of new protocol layer msgbuf.
brcmfmac: Combine protocol push hdr and bus txdata.

 drivers/net/wireless/brcm80211/brcmfmac/Makefile   |    1 -
 drivers/net/wireless/brcm80211/brcmfmac/bcdc.c     |   79 +--
 drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c   |  629 ++++++++++++++---
 .../net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c |  552 ---------------
 drivers/net/wireless/brcm80211/brcmfmac/dhd_bus.h  |    8 +
 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c |  740 +++++++++-----------
 drivers/net/wireless/brcm80211/brcmfmac/fwil.c     |   12 +-
 drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c |   41 +-
 drivers/net/wireless/brcm80211/brcmfmac/proto.c    |    2 +-
 drivers/net/wireless/brcm80211/brcmfmac/proto.h    |   14 +-
 .../net/wireless/brcm80211/brcmfmac/sdio_chip.c    |  296 ++++----
 .../net/wireless/brcm80211/brcmfmac/sdio_chip.h    |    2 +-
 .../net/wireless/brcm80211/brcmfmac/sdio_host.h    |   82 +--
 drivers/net/wireless/brcm80211/brcmfmac/usb.c      |    1 +
 14 files changed, 1109 insertions(+), 1350 deletions(-)
 delete mode 100644 drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c
Signature · 1 line
1.7.10.4