treewide: add missing put_device calls
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 13 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | net: phy: call put_device on device_register() failuredrivers/ | +1 | 0 replies | |
| 2/4 | eisa: call put_device if device_register failsdrivers/ | +3 | 0 replies | |
| 3/4 | backlight: lcd: call put_device if device_register failsdrivers/ | +1 | 0 replies | |
| 4/4 | w1: call put_device if device_register failsdrivers/ | +2 | 4 replies |
Reviews trailers per patch
1 of 4 patches has a Reviewed-by or Acked-by.
| Patch | Evgeniy Polyakov |
|---|---|
| 1/4 | |
| 2/4 | |
| 3/4 | |
| 4/4 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/4] treewide: add missing put_device calls
Hi,
This is just the beginning of patchset-set that aims to fix possible problems caused by not calling put_device() if device_register() fails.
The root cause for the need to call put_device() is that the underlying kobject still has a reference count of 1. Thus, device.release() will not be called and the device will just sit there waiting for a put_device(). Adding the put_device() also removes the need for the call to kfree() as most release functions already call kfree() on the container of the device.
While these have not been experienced, they are potential issues and thus they need to be fixed. Also, they are a few more files that have the same kind of issue, those will be fixed if these are accepted.
(Sorry for the noise, I messed up my SMTP server so it didn't reach LKML)
The patchset consists of the following patches:
net: phy: call put_device on device_register() failure
eisa: call put_device if device_register fails
backlight: lcd: call put_device if device_register fails
w1: call put_device if device_register fails
diffstat as follows:
drivers/eisa/eisa-bus.c | 4 +++- drivers/net/phy/mdio_bus.c | 1 + drivers/video/backlight/lcd.c | 2 +- drivers/w1/w1_int.c | 5 ++--- 4 files changed, 7 insertions(+), 5 deletions(-)
--
Regards,
Levente Kurusa