Skip to content

block: add native support for NFS

Peter Lieven qemu-devel 9 versions – Applied

Status from this message: Thanks, applied to the block branch.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest5 patches 2 repliesApplied
  2. v85 patches 5 repliesSuperseded
  3. v75 patches 17 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v66 patches10 repliesSuperseded
v51 patch20 repliesSuperseded
v41 patch3 repliesSuperseded
v31 patch2 repliesSuperseded
v21 patch42 repliesSuperseded
v11 patch12 repliesSuperseded

Changes in v9 from the cover letter

- change _supported_proto for qemu-iotests 071 & 072 from generic to file

Patches in v9 Applied

#Subject and filesSizeRepliesApplied
1/5block: add native support for NFSMAINTAINERS block/Makefile.objs block/nfs.c +2 more+472 -01 reply
2/5qemu-iotests: change _supported_proto to file for various teststests/qemu-iotests/013 tests/qemu-iotests/014 tests/qemu-iotests/018 +22 more+25 -250 replies
3/5qemu-iotests: blacklist test 020 for NFS protocoltests/qemu-iotests/020+5 -00 replies
4/5qemu-iotests: enable test 016 and 025 to work with NFS protocoltests/qemu-iotests/016 tests/qemu-iotests/025+2 -20 replies
5/5qemu-iotests: enable support for NFS protocoltests/qemu-iotests/common tests/qemu-iotests/common.rc+22 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v9 yet.

Read the v9 thread

Cover letter [Qemu-devel] [PATCHv9 0/5] block: add native support for NFS

This adds v9 of the NFS protocol driver + qemu-iotest adjustments.

v8->v9:
- change _supported_proto for qemu-iotests 071 & 072 from generic to file

v7->v8:
- bump libnfs requirement to 1.9.2
- renamed NFSRPC->status to NFSRPC->ret [Benoit]
- avoid double invocation of nfs_client_close in nfs_file_create [Benoit]
- fixed error propagation in nfs_file_open [Benoit]

v6->v7:
- removed unsused and partially non-existing libnfs header file includes [Stefan]
- adjusted usage of qemu_opts_create_nofail [Stefan]
- removed patch to fix output of qemu-iotest 067
- only blacklist qemu-iotest 020 for NFS do not change proto from generic to file [Fam]

v5->v6:
- use internal qemu function to parse the NFS url [Kevin]
- zero pad short reads [Kevin, Paolo]
- added qemu-iotests patches for basic nfs protocol support

v4->v5:
- disussed with Ronnie and decided to move URL + Paramter parsing to LibNFS. This allows for URL parameter processing directly in LibNFS without altering the qemu NFS block driver. This bumps the version requirement for LibNFS to 1.9.0 though.
- added a pointer to the LibNFS readme where additional information about ROOT privilidge requirements can be found as this raised a few concerns.
- removed a trailing dot in an error statement [Fam].

v3->v4:
- finally added full implementation of bdrv_get_allocated_file_size [Stefan]
- removed trailing \n from error statements [Stefan]

v2->v3:
- rebased the stefanha/block
- use pkg_config to check for libnfs (ignoring cflags which are broken in 1.8.0) [Stefan]
- fixed NFSClient declaration [Stefan]
- renamed Task variables to task [Stefan]
- renamed NFSTask to NFSRPC [Ronnie]
- do not update bs->total_sectors in nfs_co_writev [Stefan]
- return -ENOMEM on all async call failures [Stefan,Ronnie]
- fully implement ftruncate
- use util/uri.c for URL parsing [Stefan]
- reworked nfs_file_open_common to nfs_client_open which works on NFSClient [Stefan]
- added a comment ot the connect message that libnfs support NFSv3 only at the moment.
- DID NOT add full implementation of bdrv_get_allocated_file_size because we are not in a coroutine context and I cannot do an async call here.
I could do a sync call if there would be a guarantee that no requests are in flight. [Stefan]

v1->v2:
- fixed block/Makefile.objs [Ronnie]
- do not always register a read handler [Ronnie]
- add support for reading beyond EOF [Fam]
- fixed struct and paramter naming [Fam]
- fixed overlong lines and whitespace errors [Fam]
- return return status from libnfs whereever possible [Fam]
- added comment why we set allocated_file_size to -ENOTSUP after write [Fam]
- avoid segfault when parsing filname [Fam]
- remove unused close_bh from NFSClient [Fam]
- avoid dividing and mutliplying total_size by BDRV_SECTOR_SIZE in nfs_file_create [Fam]

Peter Lieven (5):
block: add native support for NFS
qemu-iotests: change _supported_proto to file for various tests
qemu-iotests: blacklist test 020 for NFS protocol
qemu-iotests: enable test 016 and 025 to work with NFS protocol
qemu-iotests: enable support for NFS protocol

 MAINTAINERS                  |    5 +
 block/Makefile.objs          |    1 +
 block/nfs.c                  |  439 ++++++++++++++++++++++++++++++++++++++++++
 configure                    |   26 +++
 qapi-schema.json             |    1 +
 tests/qemu-iotests/013       |    2 +-
 tests/qemu-iotests/014       |    2 +-
 tests/qemu-iotests/016       |    2 +-
 tests/qemu-iotests/018       |    2 +-
 tests/qemu-iotests/019       |    2 +-
 tests/qemu-iotests/020       |    5 +
 tests/qemu-iotests/023       |    2 +-
 tests/qemu-iotests/024       |    2 +-
 tests/qemu-iotests/025       |    2 +-
 tests/qemu-iotests/026       |    2 +-
 tests/qemu-iotests/028       |    2 +-
 tests/qemu-iotests/031       |    2 +-
 tests/qemu-iotests/034       |    2 +-
 tests/qemu-iotests/036       |    2 +-
 tests/qemu-iotests/037       |    2 +-
 tests/qemu-iotests/038       |    2 +-
 tests/qemu-iotests/039       |    2 +-
 tests/qemu-iotests/043       |    2 +-
 tests/qemu-iotests/046       |    2 +-
 tests/qemu-iotests/052       |    2 +-
 tests/qemu-iotests/054       |    2 +-
 tests/qemu-iotests/059       |    2 +-
 tests/qemu-iotests/060       |    2 +-
 tests/qemu-iotests/061       |    2 +-
 tests/qemu-iotests/063       |    2 +-
 tests/qemu-iotests/069       |    2 +-
 tests/qemu-iotests/071       |    2 +-
 tests/qemu-iotests/072       |    2 +-
 tests/qemu-iotests/common    |   22 ++-
 tests/qemu-iotests/common.rc |    3 +
 35 files changed, 526 insertions(+), 30 deletions(-)
 create mode 100644 block/nfs.c
Signature · 1 line
1.7.9.5