Skip to content

allow redirect of stderr in grub_util_exec*

Andrey Borzenkov grub-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2consolidate grub_util_exec codegrub-core/osdep/unix/exec.c include/grub/emu/exec.h include/grub/osdep/exec_unix.h+68 -1080 replies
2/2use grub_util_exec_redirect_all to silence "moprobe efivars"grub-core/osdep/linux/platform.c+2 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] allow redirect of stderr in grub_util_exec*
Quoted 4 lines

Hmm ... I'm not sure we really need it at all (in grub_install_get_default_x86_platform). Directory /sys/firmware/efi is not created by module efivars and we check whether this directory exists. I think it can safely be removed.

OK, it was changed relatively recently so we still need modprobe but just need to silence it like it was before in shell code. What about the following?

Andrey Borzenkov (2):
consolidate grub_util_exec code
use grub_util_exec_redirect_all to silence "moprobe efivars"

 grub-core/osdep/linux/platform.c |   4 +-
 grub-core/osdep/unix/exec.c      | 134 +++++++++++++++++++--------------------
 include/grub/emu/exec.h          |   3 +
 include/grub/osdep/exec_unix.h   |  39 ------------
 4 files changed, 70 insertions(+), 110 deletions(-)
 delete mode 100644 include/grub/osdep/exec_unix.h
Signature · 1 line
1.8.4