Skip to content

RFC ION fixups for staging-next

John Stultz lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3staging: ion: Add HAVE_MEMBLOCK config dependencydrivers/staging/android/ion/Kconfig+1 -00 replies
2/3staging: ion: Fix possible null pointer dereferencedrivers/staging/android/ion/ion_system_heap.c+5 -03 replies
3/3staging: ion: Avoid using rt_mutexes directly.drivers/staging/android/ion/ion_heap.c drivers/staging/android/ion/ion_priv.h+11 -113 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC][PATCH 0/3] ION fixups for staging-next

Since the ION patchset landed in staging-next, there have been a few build issue reports, and this patchset tries to address them.

I've marked these as RFC, as I'd really like to get acks from Colin or someone else on the Android team on these before merging them.

The first patch is the most trivial.

The second, I not sure if it is better to free the buffer and continue looking for a smaller order, or if we should just free the buffer and return NULL.

The last patch is the one I'm least confident of. We could simply add a depends on RT_MUTEXES to the ION option, but since so few drivers directly use rt_mutexes, and there's no documentation in the code that I've noticed as to why the ion_heap uses an rt_mutex, it probably is best to just convert it to a normal mutex. If this is wrong, we can instead add the dependency and hopefully some documentation.

I'd appreciate any thoughts or comments!

thanks
-john

Cc Colin Cross <[email protected]>
Cc Android Kernel Team <[email protected]>
Cc Greg KH <[email protected]>

John Stultz (3):
staging: ion: Add HAVE_MEMBLOCK config dependency
staging: ion: Fix possible null pointer dereference
staging: ion: Avoid using rt_mutexes directly.

 drivers/staging/android/ion/Kconfig           |  1 +
 drivers/staging/android/ion/ion_heap.c        | 20 ++++++++++----------
 drivers/staging/android/ion/ion_system_heap.c |  5 +++++
 3 files changed, 16 insertions(+), 10 deletions(-)
Signature · 1 line
1.8.3.2