Skip to content

ION fixups for staging-next (v2)

John Stultz lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 3 repliesIn review

Changes in v2 from the cover letter

o Fixed up style issue Greg caught
o Reworked second patch to simplify error path and just return null if kmalloc fails
o Per Colin's suggestion, reworked third patch to use spinlocks. This ended up being a bit more complicated to get right, and I'd appreciate very close review, but it seems to be working ok in testing on both ARM and x86_64 w/o triggering any lockdep or other warnings.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3staging: ion: Add HAVE_MEMBLOCK config dependencydrivers/staging/android/ion/Kconfig+1 -01 reply
2/3staging: ion: Fix possible null pointer dereferencedrivers/staging/android/ion/ion_system_heap.c+6 -11 reply
3/3staging: ion: Avoid using rt_mutexes directly.drivers/staging/android/ion/ion_heap.c drivers/staging/android/ion/ion_priv.h+20 -133 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchColin Cross
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] ION fixups for staging-next (v2)

Since the ION patchset landed in staging-next, there have been a few build issue reports, and this patchset tries to address them.

Dropped the RFC, as I think the first two are good to go, but I'd still like to get acks from Colin or someone else on the Android team on all of these before merging these, as some bits were a bit more complex then I'd like.

Changes in v2:
o Fixed up style issue Greg caught
o Reworked second patch to simplify error path and just return null if kmalloc fails
o Per Colin's suggestion, reworked third patch to use spinlocks. This ended up being a bit more complicated to get right, and I'd appreciate very close review, but it seems to be working ok in testing on both ARM and x86_64 w/o triggering any lockdep or other warnings.

I'd appreciate any thoughts or comments!

thanks
-john

Cc Colin Cross <[email protected]>
Cc Android Kernel Team <[email protected]>
Cc Greg KH <[email protected]>

John Stultz (3):
staging: ion: Add HAVE_MEMBLOCK config dependency
staging: ion: Fix possible null pointer dereference
staging: ion: Avoid using rt_mutexes directly.

 drivers/staging/android/ion/Kconfig           |  1 +
 drivers/staging/android/ion/ion_heap.c        | 31 ++++++++++++++++-----------
 drivers/staging/android/ion/ion_priv.h        |  2 +-
 drivers/staging/android/ion/ion_system_heap.c |  7 +++++-
 4 files changed, 27 insertions(+), 14 deletions(-)
Signature · 1 line
1.8.3.2