Timekeeping fixes for 3.13 via tip/timers/urgent
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 8 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | timekeeping: Fix lost updates to tai adjustmentkernel/ | +2 | 0 replies | |
| 2/3 | timekeeping: Fix potential lost pv notification of time changekernel/ | +5 | 8 replies | |
| 2/3 | timekeeping: Fix potential lost pv notification of time changekernel/ | +5 | 0 replies | |
| 3/3 | timekeeping: Avoid possible deadlock from clock_was_set_delayedkernel/ | +16 | 0 replies |
Reviews trailers per patch
None of the 4 patches has a Reviewed-by or Acked-by.
| Patch | Sasha Levin |
|---|---|
| 1/3 | |
| 2/3 | |
| 2/3 | |
| 3/3 | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] Timekeeping fixes for 3.13 via tip/timers/urgent
Hey Ingo, Thomas,
Here are the timekeeping fixes I'd like to submit for 3.13.
The first is a regression caused by the shadow time code that causes the tai offset to be overwritten. This keeps ntpd from being able to initialize the tai_offset.
The second fixes an issue where the action flag returned from accumulate_nsecs_to_secs was not being passed all the way down to where we update the pv notifiers. While not critical, this change is a prerequisite for the following critical fix.
The last patch fixes the potential timekeeping/hrtimer deadlock Sahsa found caused by clock_was_set_delayed() not actually being safe to call while holding the timekeeping lock. This leverages the previous patch to move the call outside the lock.
I have a number of other fixes queued, including the cleanup to the tick code that will let us stop using clock_was_set_delayed all together in the timekeeping code, but I'll save those for 3.14.
thanks
-john
John Stultz (3):
timekeeping: Fix lost updates to tai adjustment
timekeeping: Fix potential lost pv notification of time change
timekeeping: Avoid possible deadlock from clock_was_set_delayed
kernel/time/timekeeping.c | 31 +++++++++++++++++++++++-------- 1 file changed, 23 insertions(+), 8 deletions(-)
Signature · 1 line
1.8.3.2