perf report: Add support to accumulate hist periods (v3)
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest18 patches 16 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/18 | perf sort: Compare addresses if no symbol infotools/ | +8 | 4 replies | |
| 2/18 | perf sort: Do not compare dso againtools/ | +8 | 1 reply | |
| 3/18 | perf tools: Do not pass period and weight to add_hist_entry()tools/ | +5 | 1 reply | |
| 4/18 | perf tools: Introduce struct add_entry_itertools/ | +300 | 2 replies | |
| 5/18 | perf hists: Convert hist entry functions to use struct he_stattools/ | +11 | 0 replies | |
| 6/18 | perf hists: Add support for accumulated stat of hist entrytools/ tools/ tools/ | +20 | 0 replies | |
| 7/18 | perf hists: Check if accumulated when adding a hist entrytools/ tools/ tools/ +4 more | +26 | 0 replies | |
| 8/18 | perf hists: Accumulate hist entry stat based on the callchaintools/ tools/ | +136 | 0 replies | |
| 9/18 | perf tools: Update cpumode for each cumulative entrytools/ | +31 | 0 replies | |
| 10/18 | perf report: Cache cumulative callchainstools/ | +48 | 0 replies | |
| 11/18 | perf hists: Sort hist entries by accumulated periodtools/ tools/ | +18 | 0 replies | |
| 12/18 | perf ui/hist: Add support to accumulated hist stattools/ tools/ | +46 | 0 replies | |
| 13/18 | perf ui/browser: Add support to accumulated hist stattools/ | +17 | 0 replies | |
| 14/18 | perf ui/gtk: Add support to accumulated hist stattools/ | +16 | 0 replies | |
| 15/18 | perf tools: Apply percent-limit to cumulative percentagetools/ tools/ tools/ | +44 | 0 replies | |
| 16/18 | perf tools: Add more hpp helper functionstools/ tools/ | +20 | 0 replies | |
| 17/18 | perf report: Add --cumulate optiontools/ tools/ | +16 | 0 replies | |
| 18/18 | perf report: Add report.cumulate config optiontools/ | +4 | 0 replies |
Reviews trailers per patch
3 of 18 patches have a Reviewed-by or Acked-by.
| Patch | Jiri Olsa |
|---|---|
| 1/18 | A-b |
| 2/18 | A-b |
| 3/18 | A-b |
| 4/18 | |
| 5/18 | |
| 6/18 | |
| 7/18 | |
| 8/18 | |
| 9/18 | |
| 10/18 | |
| 11/18 | |
| 12/18 | |
| 13/18 | |
| 14/18 | |
| 15/18 | |
| 16/18 | |
| 17/18 | |
| 18/18 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3)
Hello,
This is my third attempt to implement cumulative hist period report. This work begins from Arun's SORT_INCLUSIVE patch [1] but I completely rewrote it from scratch.
Please see the patch 04/18. I refactored functions that add hist entries with struct add_entry_iter. While I converted all functions carefully, it'd be better anyone can test and confirm that I didn't mess up something - especially for branch stack and mem stuff.
This patchset basically adds period in a sample to every node in the callchain. A hist_entry now has an additional fields to keep the cumulative period if --cumulate option is given on perf report.
I changed the option as a separate --cumulate and added a new "Total" column (and renamed the default "Overhead" column into "Self"). The output will be sorted by total (cumulative) overhead for now. The reason I changed to the --cumulate is that I still think it's much different from other --callchain options and I plan to add support for showing (remaining) callchains to cumulative entries too. The --callchain option will take care of it even with --cumulate option.
I know that the UI should be changed also to be more flexible as Ingo requested, but I'd like to do this first and then move to work on the next. I also added a new config option to enable it by default.
* changes in v3:
- change to --cumulate option
- fix a couple of bugs (Jiri, Rodrigo)
- rename some help functions (Arnaldo)
- cache previous hist entries rathen than just symbol and dso
- add some preparatory cleanups
- add report.cumulate config option
Let me show you an example:
$ cat abc.c
#define barrier() asm volatile("" ::: "memory") void a(void)
{
int i;
for (i = 0; i < 1000000; i++)
barrier();
}
void b(void)
{
a();
}
void c(void)
{
b();
}
int main(void)
{
c();
return 0;
}With this simple program I ran perf record and report:
$ perf record -g -e cycles:u ./abc
$ perf report --stdio
88.29% abc abc [.] a
|
--- a
b
c
main
__libc_start_main 9.43% abc ld-2.17.so [.] _dl_relocate_object
|
--- _dl_relocate_object
dl_main
_dl_sysdep_start
2.27% abc [kernel.kallsyms] [k] page_fault
|
--- page_fault
|
|--95.94%-- _dl_sysdep_start
| _dl_start_user
|
--4.06%-- _start
0.00% abc ld-2.17.so [.] _start
|
--- _startWhen the -g cumulative option is given, it'll be shown like this:
$ perf report --cumulate --stdio
# Self Total Command Shared Object Symbol
# ........ ........ ....... ................. .......................
#
0.00% 88.29% abc libc-2.17.so [.] __libc_start_main
0.00% 88.29% abc abc [.] main
0.00% 88.29% abc abc [.] c
0.00% 88.29% abc abc [.] b
88.29% 88.29% abc abc [.] a
0.00% 11.61% abc ld-2.17.so [.] _dl_sysdep_start
0.00% 9.43% abc ld-2.17.so [.] dl_main
9.43% 9.43% abc ld-2.17.so [.] _dl_relocate_object
2.27% 2.27% abc [kernel.kallsyms] [k] page_fault
0.00% 2.18% abc ld-2.17.so [.] _dl_start_user
0.00% 0.10% abc ld-2.17.so [.] _start As you can see __libc_start_main -> main -> c -> b -> a callchain show up in the output.
I know it have some rough edges or even bugs, but I really want to release it and get reviews. It does not handle event groups and annotations yet.
You can also get this series on 'perf/cumulate-v3' branch in my tree at:
git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
Any comments are welcome, thanks.
Namhyung
[1] https://lkml.org/lkml/2012/3/31/6
Namhyung Kim (18):
perf sort: Compare addresses if no symbol info
perf sort: Do not compare dso again
perf tools: Do not pass period and weight to add_hist_entry() perf tools: Introduce struct add_entry_iter
perf hists: Convert hist entry functions to use struct he_stat perf hists: Add support for accumulated stat of hist entry perf hists: Check if accumulated when adding a hist entry perf hists: Accumulate hist entry stat based on the callchain perf tools: Update cpumode for each cumulative entry perf report: Cache cumulative callchains
perf hists: Sort hist entries by accumulated period perf ui/hist: Add support to accumulated hist stat perf ui/browser: Add support to accumulated hist stat perf ui/gtk: Add support to accumulated hist stat perf tools: Apply percent-limit to cumulative percentage perf tools: Add more hpp helper functions
perf report: Add --cumulate option
perf report: Add report.cumulate config option
tools/perf/Documentation/perf-report.txt | 5 + tools/perf/builtin-annotate.c | 3 +- tools/perf/builtin-diff.c | 2 +- tools/perf/builtin-report.c | 679 ++++++++++++++++++++++++------- tools/perf/builtin-top.c | 2 +- tools/perf/tests/hists_link.c | 4 +- tools/perf/ui/browsers/hists.c | 51 ++- tools/perf/ui/gtk/hists.c | 27 +- tools/perf/ui/hist.c | 62 +++ tools/perf/ui/stdio/hist.c | 13 +- tools/perf/util/hist.c | 79 +++- tools/perf/util/hist.h | 7 +- tools/perf/util/sort.c | 22 +- tools/perf/util/sort.h | 1 + tools/perf/util/symbol.h | 1 + 15 files changed, 761 insertions(+), 197 deletions(-)
Signature · 1 line
1.7.11.7