Skip to content

usb: gadget: fotg210: workaround & new hardware support

Kuo-Jung Su u-boot 4 versions – New

Get series with b4
b4 am CAK65tU7o0p-gN6R7nX9OVthqKZ57=xOgxFkJw11grw1smYQQuQ@mail.gmail.com

Versions newest first · linked by author and title

  1. v2 Latest posting 3/30 of 2 patches 0 repliesNew
  2. v2 posting 2/30 of 2 patches 0 repliesSuperseded
  3. v2 posting 1/32 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches0 repliesSuperseded

Patches in v2 posting 3/3 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [U-Boot] [PATCH v2 0/2] usb: gadget: fotg210: workaround & new hardware support

2013/12/23 Marek Vasut <[email protected]>:

Quoted 40 lines · Kuo-Jung Su
Quoted 39 lines

2013/12/20 Marek Vasut <[email protected]>:

Quoted 24 lines · Kuo-Jung Su
Quoted 23 lines

From: Kuo-Jung Su <[email protected]>

1. It's known that EP0 fifo empty indication is not reliable, an extra delay is necessary to avoid data corruption while handling packets with size greater than 64 bytes.

2. Since hardware revision 1.11.0, some fields of interrupt status registers are now write-1-clear.

Changes for v2:
- usb: gadget: fotg210: add w1c interrupt status support:
By writting 1 then 0 to get rid of the use of CONFIG_USB_GADGET_FOTG210_ISRW1C.
Thanks for Marek's comments.

- usb: gadget: fotg210: EP0 fifo empty indication is non-reliable

udelay_masked() -> udelay(), and patch comment updates.

Kuo-Jung Su (2):
usb: gadget: fotg210: add w1c interrupt status support
usb: gadget: fotg210: EP0 fifo empty indication is non-reliable

Quoted 7 lines
Quoted 2 lines
 drivers/usb/gadget/fotg210.c |   15 +++++++++++++++
 1 file changed, 15 insertions(+)

Applied both , thanks!

btw. is this FOTG210 stuff used by any platform or is this just a dead code ?

It's still an active IP, and the only USB 2.0 (host, device, otg) controller we have currently in Faraday.

It's used in upcoming Faraday A369 SoC patch set (I'm still waiting for the dependant NAND driver: ftnandc021 to be commited),

Quoted 7 lines
Quoted 2 lines

and the new SoC platforms (For politics reason, they won't be released by myself.) in year 2013.

OK, glad to see this won't be dead code soon. Next time, I suppose it'd be better to commit platform first, drivers afterwards, so we dont have dead code for an extended period of time.

Got it, thanks

Signature · 2 lines
Best wishes,
Kuo-Jung Su