Skip to content

perf tools: A couple of TUI improvements

Namhyung Kim lkml 1 version Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 14 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/6perf report: Use pr_*() functions if possibletools/perf/builtin-report.c+13 -114 replies
2/6perf tools: Introduce struct perf_logtools/perf/Makefile.perf tools/perf/perf.c tools/perf/util/debug.h +1 more+124 -02 replies
3/6perf tools: Get rid of a duplicate va_end()tools/perf/util/debug.c+0 -12 replies
4/6perf tools: Save message when pr_*() was calledtools/perf/util/debug.c+6 -00 replies
5/6perf ui/tui: Implement log windowtools/perf/Makefile.perf tools/perf/ui/browser.h tools/perf/ui/browsers/hists.c +1 more+98 -00 replies
6/6perf ui/tui: Implement header windowtools/perf/Makefile.perf tools/perf/ui/browser.h tools/perf/ui/browsers/header.c +1 more+123 -00 replies

Reviews trailers per patch

2 of 6 patches have a Reviewed-by or Acked-by.

PatchJiri Olsa
1/6A-b
2/6
3/6A-b
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCHSET 0/6] perf tools: A couple of TUI improvements

Hello,

I was playing with TUI code and added two new windows. One for showing log messages and another for showing header information. (Maybe they can be implemented on the GTK code too someday.)

Please try to use it! :)

I put the patches on 'perf/tui-v1' branch in my tree:

git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Any feedbacks are more than welcome, thanks
Namhyung

Namhyung Kim (6):
perf report: Use pr_*() functions if possible
perf tools: Introduce struct perf_log
perf tools: Get rid of a duplicate va_end()
perf tools: Save message when pr_*() was called
perf ui/tui: Implement log window
perf ui/tui: Implement header window

 tools/perf/Makefile.perf        |   3 ++
 tools/perf/builtin-report.c     |  24 +++++----
 tools/perf/perf.c               |   3 ++
 tools/perf/ui/browser.h         |   3 ++
 tools/perf/ui/browsers/header.c | 116 ++++++++++++++++++++++++++++++++++++++++
 tools/perf/ui/browsers/hists.c  |   8 +++
 tools/perf/ui/browsers/log.c    |  92 +++++++++++++++++++++++++++++++
 tools/perf/util/debug.c         |   7 ++-
 tools/perf/util/debug.h         |  15 ++++++
 tools/perf/util/log.c           | 105 ++++++++++++++++++++++++++++++++++++
 10 files changed, 364 insertions(+), 12 deletions(-)
 create mode 100644 tools/perf/ui/browsers/header.c
 create mode 100644 tools/perf/ui/browsers/log.c
 create mode 100644 tools/perf/util/log.c
Signature · 1 line
1.7.11.7