Skip to content

Make PC8 become part of runtime PM

Paulo Zanoni intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19drm/i915: rename modeset_update_power_wellsdrivers/gpu/drm/i915/intel_display.c+2 -21 reply
2/19drm/i915: get/put runtime PM without holding rps.hw_lockdrivers/gpu/drm/i915/i915_debugfs.c+7 -54 replies
3/19drm/i915: add forcewake functions that don't touch runtime PMdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_uncore.c+24 -104 replies
4/19drm/i915: extract __hsw_do_{en, dis}able_package_c8drivers/gpu/drm/i915/intel_display.c+38 -261 reply
5/19drm/i915: make PC8 be part of runtime PM suspend/resumedrivers/gpu/drm/i915/i915_dma.c drivers/gpu/drm/i915/i915_drv.c drivers/gpu/drm/i915/i915_drv.h +3 more+26 -440 replies
6/19drm/i915: get/put runtime PM when we get/put a power domaindrivers/gpu/drm/i915/intel_pm.c+4 -01 reply
7/19drm/i915: remove dev_priv->pc8.requirements_metdrivers/gpu/drm/i915/i915_debugfs.c drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_display.c +1 more+1 -590 replies
8/19drm/i915: make gpu_idle be part of runtime PM, not PC8drivers/gpu/drm/i915/i915_debugfs.c drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_display.c +1 more+24 -200 replies
9/19drm/i915: kill pc8.disable_countdrivers/gpu/drm/i915/i915_debugfs.c drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_display.c +1 more+0 -170 replies
10/19drm/i915: remove an indirection level on PC8 functionsdrivers/gpu/drm/i915/intel_display.c+2 -140 replies
11/19drm/i915: don't get/put PC8 reference on freeze/thawdrivers/gpu/drm/i915/i915_drv.c+0 -50 replies
12/19drm/i915: get/put runtime PM references for GMBUS and DP AUXdrivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_drv.h drivers/gpu/drm/i915/intel_i2c.c +1 more+4 -170 replies
13/19drm/i915: don't get/put PC8 when getting/putting power wellsdrivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_drv.h drivers/gpu/drm/i915/intel_pm.c+2 -320 replies
14/19drm/i915: remove dev_priv->pc8.enableddrivers/gpu/drm/i915/i915_debugfs.c drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_display.c +1 more+0 -90 replies
15/19drm/i915: move pc8.irqs_disabled to pm.irqs_disableddrivers/gpu/drm/i915/i915_debugfs.c drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem.c +4 more+42 -480 replies
16/19drm/i915: kill struct i915_package_c8drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_pm.c+0 -70 replies
17/19drm/i915: rename __hsw_do_{en, dis}able_pc8drivers/gpu/drm/i915/i915_drv.c drivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_drv.h+6 -60 replies
18/19drm/i915: update the PC8 and runtime PM documentation.drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_display.c+38 -400 replies
19/19drm/i915: init pm.suspended earlierdrivers/gpu/drm/i915/intel_pm.c+1 -20 replies

Reviews trailers per patch

4 of 19 patches have a Reviewed-by or Acked-by.

PatchImre Deak
1/19R-b
2/19R-b
3/19R-b
4/19R-b
5/19
6/19
7/19
8/19
9/19
10/19
11/19
12/19
13/19
14/19
15/19
16/19
17/19
18/19
19/19

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/19] Make PC8 become part of runtime PM

From: Paulo Zanoni <[email protected]>

Hi

This patch series makes the PC8 feature become part of the runtime PM feature. They won't be 2 separate features anymore, but just one. You can find some good arguments for this in the commit message of patch 5.

- Patch 1 is just a bikeshed that can be discarded if needed.
- Patches 2-4 do some necessary work to merge PC8 and runtime PM.
- Patch 5 actually merges the two features. It just does the minimal work required to merge the feature and pass all the tests on the test suite.
- Patches 6-19 do many cleanups that become possible since the features got merged. Each patch contains just a very small chunk of code, to make it easier for reviewers (also for tracking regressions while I was developing the code!).

I hope that with this, it will also be much easier to add runtime PM support on other platforms. I also think I addressed many of Daniel's comments regarding how we do the put/get calls, but there may still be something left: please tell me if you find something!

I also didn't take care of implementing the interrupt changes suggested by Daniel. This won't be trivial and will require its own patch series.

Thanks,
Paulo

Paulo Zanoni (19):
drm/i915: rename modeset_update_power_wells drm/i915: get/put runtime PM without holding rps.hw_lock drm/i915: add forcewake functions that don't touch runtime PM drm/i915: extract __hsw_do_{en,dis}able_package_c8 drm/i915: make PC8 be part of runtime PM suspend/resume drm/i915: get/put runtime PM when we get/put a power domain drm/i915: remove dev_priv->pc8.requirements_met drm/i915: make gpu_idle be part of runtime PM, not PC8 drm/i915: kill pc8.disable_count
drm/i915: remove an indirection level on PC8 functions drm/i915: don't get/put PC8 reference on freeze/thaw drm/i915: get/put runtime PM references for GMBUS and DP AUX drm/i915: don't get/put PC8 when getting/putting power wells drm/i915: remove dev_priv->pc8.enabled
drm/i915: move pc8.irqs_disabled to pm.irqs_disabled drm/i915: kill struct i915_package_c8
drm/i915: rename __hsw_do_{en,dis}able_pc8 drm/i915: update the PC8 and runtime PM documentation. drm/i915: init pm.suspended earlier

 drivers/gpu/drm/i915/i915_debugfs.c  |  23 ++---
 drivers/gpu/drm/i915/i915_dma.c      |   2 -
 drivers/gpu/drm/i915/i915_drv.c      |  19 ++--
 drivers/gpu/drm/i915/i915_drv.h      |  74 +++++---------
 drivers/gpu/drm/i915/i915_gem.c      |   2 +-
 drivers/gpu/drm/i915/i915_irq.c      |  58 +++++------
 drivers/gpu/drm/i915/intel_display.c | 186 +++++++++--------------------------
 drivers/gpu/drm/i915/intel_dp.c      |   4 +-
 drivers/gpu/drm/i915/intel_drv.h     |  11 +--
 drivers/gpu/drm/i915/intel_i2c.c     |   4 +-
 drivers/gpu/drm/i915/intel_pm.c      |  45 +++------
 drivers/gpu/drm/i915/intel_uncore.c  |  30 ++++--
 12 files changed, 158 insertions(+), 300 deletions(-)
Signature · 1 line
1.8.3.1