Skip to content

treewide: add all missing put_device calls

Levente Kurusa lkml 1 version Applied

Status from this message: Applied, thanks. Please use subject lines matching the standard for the

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest38 patches 25 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/38sh: dma-sysfs: add missing put_device callarch/sh/drivers/dma/dma-sysfs.c+3 -10 replies
2/38powerpc: qe_lib: add missing put_device callarch/powerpc/sysdev/qe_lib/qe_ic.c+1 -00 replies
3/38powerpc: cell: add missing put_device callarch/powerpc/platforms/cell/spu_base.c+1 -00 replies
4/38powerpc: kernel: add missing put_device callarch/powerpc/kernel/vio.c+1 -00 replies
5/38sparc: kernel: add missing put_device callarch/sparc/kernel/vio.c+1 -11 reply
6/38arm: mach-s3c64: add missing put_device callarch/arm/mach-s3c64xx/dma.c+1 -00 replies
7/38arm: locomo: add missing put_device callarch/arm/common/locomo.c+3 -60 replies
8/38arm: mach-rpc: add missing put_device callarch/arm/mach-rpc/ecard.c+3 -10 replies
9/38arm: mach-imx: add missing put_device callsarch/arm/mach-imx/devices/devices.c+5 -20 replies
10/38arm: exynos: add missing put_device callarch/arm/mach-exynos/common.c+7 -10 replies
11/38arm: mach-integrator: add missing put_device callarch/arm/mach-integrator/lm.c+3 -10 replies
12/38arm: s5pv210: add missing put_device callarch/arm/mach-s5pv210/common.c+7 -10 replies
13/38arm: s390: add missing put_device callarch/s390/kernel/time.c+3 -10 replies
14/38mips: txx9: add missing put_device callarch/mips/txx9/generic/setup.c+17 -100 replies
15/38mips: txx9: 7segled: add missing put_device callarch/mips/txx9/generic/7segled.c+10 -30 replies
16/38mips: sgi-ip22: add missing put_device callarch/mips/sgi-ip22/ip22-gio.c+8 -10 replies
17/38parisc: kernel: add missing put_device callarch/parisc/kernel/drivers.c+1 -11 reply
18/38ia64: kernel: add missing put_device callarch/ia64/sn/kernel/tiocx.c+1 -10 replies
19/38net: atm: add missing put_device callnet/atm/atm_sysfs.c+3 -11 reply
20/38net: iucv: add missing put_device callnet/iucv/af_iucv.c+3 -11 reply
21/38workqueue: add missing put_device callkernel/workqueue.c+1 -15 replies
22/38sound: ac97: add missing put_device callsound/pci/ac97/ac97_codec.c+1 -01 reply
23/38sound: soc: add missing put_device callsound/soc/soc-core.c+1 -01 reply
24/38pcmcia: add missing put_device calldrivers/pcmcia/cs.c+1 -00 replies
25/38pnp: card: add missing put_device calldrivers/pnp/card.c+1 -01 reply
26/38xen: xenbus: add missing put_device calldrivers/xen/xenbus/xenbus_probe.c+3 -10 replies
26/38xen: xenbus: add missing put_device calldrivers/xen/xenbus/xenbus_probe.c+3 -18 replies
27/38superhyway: add missing put_device calldrivers/sh/superhyway/superhyway.c+5 -10 replies
28/38superhyway: intc: add missing put_device calldrivers/sh/intc/core.c+3 -10 replies
29/38superhyway: maple: add missing put_device calldrivers/sh/maple/maple.c+9 -140 replies
30/38vlynq: add missing put_device calldrivers/vlynq/vlynq.c+4 -11 reply
32/38pcie: add missing put_device calldrivers/pci/pcie/portdrv_core.c+1 -13 replies
33/38scsi: transport: add missing put_device calldrivers/scsi/scsi_transport_iscsi.c+4 -61 reply
34/38infiniband: core: add missing put_device calldrivers/infiniband/core/sysfs.c+3 -10 replies
35/38media: bt8xx: add missing put_device calldrivers/media/pci/bt8xx/bttv-gpio.c+1 -10 replies
36/38dio: add missing put_device calldrivers/dio/dio.c+1 -00 replies
37/38uwb: umc-dev: add missing put_device calldrivers/uwb/umc-dev.c+1 -00 replies
38/38bcma: add missing put_device calldrivers/bcma/main.c+1 -00 replies

Reviews trailers per patch

1 of 38 patches has a Reviewed-by or Acked-by.

PatchTejun HeoFlorian Fainelli
1/38
2/38
3/38
4/38
5/38
6/38
7/38
8/38
9/38
10/38
11/38
12/38
13/38
14/38
15/38
16/38
17/38
18/38
19/38
20/38
21/38Nacked-by
22/38
23/38
24/38
25/38
26/38
26/38
27/38
28/38
29/38
30/38A-b
32/38
33/38
34/38
35/38
36/38
37/38
38/38

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/38] treewide: add all missing put_device calls

Hi,

this is the second part of the patchset-set that aims to add missing put_device calls when a device_register() call fails. While these issues are only potential issues, i.e. they haven't been experienced, they are issues and need to be fixed.

Root cause for the need for the put_device is that under a struct device lies a kobject and under that a kref. If device_register() fails, then the kref has already been initialized to reference count of one. This means that it still exists and hence can cause problems if it has been kfree'd.

The patchset consists of the following patches:

Levente Kurusa (38):
sh: dma-sysfs: add missing put_device call
powerpc: qe_lib: add missing put_device call
powerpc: cell: add missing put_device call
powerpc: kernel: add missing put_device call
sparc: kernel: add missing put_device call
arm: mach-s3c64: add missing put_device call
arm: locomo: add missing put_device call
arm: mach-rpc: add missing put_device call
arm: mach-imx: add missing put_device calls
arm: exynos: add missing put_device call
arm: mach-integrator: add missing put_device call
arm: s5pv210: add missing put_device call
arm: s390: add missing put_device call
mips: txx9: add missing put_device call
mips: txx9: add missing put_device call
mips: sgi-ip22: add missing put_device call
parisc: kernel: add missing put_device call
ia64: kernel: add missing put_device call
net: atm: add missing put_device call
net: iucv: add missing put_device call
workqueue: add missing put_device call
sound: ac97: add missing put_device call
sound: soc: add missing put_device call
pcmcia: add missing put_device call
pnp: card: add missing put_device call
xen: xenbus: add missing put_device call
superhyway: add missing put_device call
superhyway: intc: add missing put_device call
superhyway: maple: add missing put_device call
vlynq: add missing put_device call
firewire: add missing put_device call
pcie: add missing put_device call
scsi: transport: add missing put_device call
infiniband: core: add missing put_device call
media: bt8xx: add missing put_device call
dio: add missing put_device call
uwb: umc-dev: add missing put_device call
bcma: add missing put_device call

diffstat as follows:

	 arch/arm/common/locomo.c               |    9 +++------
	 arch/arm/mach-exynos/common.c          |    8 +++++++-
	 arch/arm/mach-imx/devices/devices.c    |    7 +++++--
	 arch/arm/mach-integrator/lm.c          |    4 +++-
	 arch/arm/mach-rpc/ecard.c              |    4 +++-
	 arch/arm/mach-s3c64xx/dma.c            |    1 +
	 arch/arm/mach-s5pv210/common.c         |    8 +++++++-
	 arch/ia64/sn/kernel/tiocx.c            |    2 +-
	 arch/mips/sgi-ip22/ip22-gio.c          |    9 ++++++++-
	 arch/mips/txx9/generic/7segled.c       |   13 ++++++++++---
	 arch/mips/txx9/generic/setup.c         |   27 +++++++++++++++++----------
	 arch/parisc/kernel/drivers.c           |    2 +-
	 arch/powerpc/kernel/vio.c              |    1 +
	 arch/powerpc/platforms/cell/spu_base.c |    1 +
	 arch/powerpc/sysdev/qe_lib/qe_ic.c     |    1 +
	 arch/s390/kernel/time.c                |    4 +++-
	 arch/sh/drivers/dma/dma-sysfs.c        |    4 +++-
	 arch/sparc/kernel/vio.c                |    2 +-
	 drivers/bcma/main.c                    |    1 +
	 drivers/dio/dio.c                      |    1 +
	 drivers/firewire/core-device.c         |    9 ++++-----
	 drivers/infiniband/core/sysfs.c        |    4 +++-
	 drivers/media/pci/bt8xx/bttv-gpio.c    |    2 +-
	 drivers/pci/pcie/portdrv_core.c        |    2 +-
	 drivers/pcmcia/cs.c                    |    1 +
	 drivers/pnp/card.c                     |    1 +
	 drivers/scsi/scsi_transport_iscsi.c    |   10 ++++------
	 drivers/sh/intc/core.c                 |    4 +++-
	 drivers/sh/maple/maple.c               |   23 +++++++++--------------
	 drivers/sh/superhyway/superhyway.c     |    6 +++++-
	 drivers/uwb/umc-dev.c                  |    1 +
	 drivers/vlynq/vlynq.c                  |    5 ++++-
	 drivers/xen/xenbus/xenbus_probe.c      |    4 +++-
	 kernel/workqueue.c                     |    2 +-
	 net/atm/atm_sysfs.c                    |    4 +++-
	 net/iucv/af_iucv.c                     |    4 +++-
	 sound/pci/ac97/ac97_codec.c            |    1 +
	 sound/soc/soc-core.c                   |    1 +
	 38 files changed, 127 insertions(+), 66 deletions(-)
Cc Levente Kurusa <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>

--
Regards,
Levente Kurusa