Skip to content

perf tools: A couple of TUI improvements (v2)

Namhyung Kim lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7perf report: Use pr_*() functions if possibletools/perf/builtin-report.c+4 -40 replies
2/7perf report: Print session information only if --stdio is giventools/perf/builtin-report.c+9 -70 replies
3/7perf tools: Introduce struct perf_logtools/perf/Makefile.perf tools/perf/perf.c tools/perf/util/debug.h +1 more+124 -00 replies
4/7perf tools: Save message when pr_*() was calledtools/perf/util/debug.c+6 -00 replies
5/7perf ui/tui: Implement log windowtools/perf/Makefile.perf tools/perf/ui/browser.h tools/perf/ui/browsers/hists.c +1 more+117 -00 replies
6/7perf ui/tui: Implement header windowtools/perf/Makefile.perf tools/perf/ui/browser.h tools/perf/ui/browsers/header.c +1 more+125 -00 replies
7/7perf ui/tui: Filter messages in log windowtools/perf/ui/browsers/log.c+61 -10 replies
7/7perf ui/tui: Filter messages in log windowtools/perf/ui/browsers/log.c+68 -20 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by.

PatchJiri Olsa
1/7
2/7
3/7
4/7
5/7
6/7
7/7Requested-by Requested-by
7/7Requested-by Requested-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCHSET 0/7] perf tools: A couple of TUI improvements (v2)

Hello,

I was playing with TUI code and added two new windows. One for showing log messages and another for showing header information. (Maybe they can be implemented on the GTK code too someday.)

* changes from v1)
- fix segfault on perf top (Ingo)
- split print function handling patch (Arnaldo)
- add filtering support on log window (Jiri, Ingo)

I put the patches on 'perf/tui-v2' branch in my tree:

git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Any feedbacks are more than welcome, thanks
Namhyung

Namhyung Kim (7):
perf report: Use pr_*() functions if possible
perf report: Print session information only if --stdio is given perf tools: Introduce struct perf_log
perf tools: Save message when pr_*() was called
perf ui/tui: Implement log window
perf ui/tui: Implement header window
perf ui/tui: Filter messages in log window

 tools/perf/Makefile.perf        |   3 +
 tools/perf/builtin-report.c     |  24 +++---
 tools/perf/perf.c               |   3 +
 tools/perf/ui/browser.h         |   3 +
 tools/perf/ui/browsers/header.c | 116 +++++++++++++++++++++++++++
 tools/perf/ui/browsers/hists.c  |  10 +++
 tools/perf/ui/browsers/log.c    | 171 ++++++++++++++++++++++++++++++++++++++++
 tools/perf/util/debug.c         |   6 ++
 tools/perf/util/debug.h         |  15 ++++
 tools/perf/util/log.c           | 105 ++++++++++++++++++++++++
 10 files changed, 445 insertions(+), 11 deletions(-)
 create mode 100644 tools/perf/ui/browsers/header.c
 create mode 100644 tools/perf/ui/browsers/log.c
 create mode 100644 tools/perf/util/log.c
Signature · 1 line
1.7.11.7