Skip to content

Timekeeping fixes for 3.13? (v2)

John Stultz lkml stable xen-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3timekeeping: Fix lost updates to tai adjustmentkernel/time/timekeeping.c+2 -10 replies
2/3timekeeping: Fix potential lost pv notification of time changekernel/time/timekeeping.c+11 -90 replies
2/3timekeeping: Fix potential lost pv notification of time changekernel/time/timekeeping.c+11 -90 replies
3/3timekeeping: Avoid possible deadlock from clock_was_set_delayedkernel/time/timekeeping.c+16 -20 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by.

PatchSasha Levin
1/3
2/3
2/3
3/3T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] Timekeeping fixes for 3.13? (v2)

Hey Ingo, Thomas,
Here are the timekeeping fixes I was hoping to submit for 3.13,
including the variable naming tweaks you wanted to see.

However, as I've been thinking about this a bit more, I'm a little on the fence about sending these out this late in the -rc cycle. The lockdep splat is new in 3.13 due to the seqlock lockdep enablement, but the actual potential deadlock is not new.

Also, given its so close to the holiday week, it might be wise to push off to 3.14 with these. Does that sound reasonable? If so please just apply to tip/timers/core instead, and I'll send Thomas the rest of my 3.14 queue soon.

The changes here are:

The first is a regression caused by the shadow time code that causes the tai offset to be overwritten. This keeps ntpd from being able to initialize the tai_offset.

The second fixes an issue where the action flag returned from accumulate_nsecs_to_secs was not being passed all the way down to where we update the pv notifiers. While not critical, this change is a prerequisite for the following critical fix.

The last patch fixes the potential timekeeping/hrtimer deadlock Sasha found caused by clock_was_set_delayed() not actually being safe to call while holding the timekeeping lock. This leverages the previous patch to move the call outside the lock.

I have a number of other fixes queued, including the cleanup to the tick code that will let us stop using clock_was_set_delayed all together in the timekeeping code, but I'll save those for 3.14.

thanks
-john

Cc Sasha Levin <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Prarit Bhargava <[email protected]>
Cc Richard Cochran <[email protected]>
Cc Ingo Molnar <[email protected]>

John Stultz (3):
timekeeping: Fix lost updates to tai adjustment
timekeeping: Fix potential lost pv notification of time change
timekeeping: Avoid possible deadlock from clock_was_set_delayed

 kernel/time/timekeeping.c | 41 +++++++++++++++++++++++++++++------------
 1 file changed, 29 insertions(+), 12 deletions(-)
Signature · 1 line
1.8.3.2