Skip to content

tcg/i386: use movbe instruction in qemu_ldst routines

Aurelien Jarno qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5disas/i386.c: disassemble movbe instructiondisas/i386.c+4 -41 reply
2/5tcg/i386: remove hardcoded P_REXW valuetcg/i386/tcg-target.c+1 -11 reply
3/5tcg/i386: add support for three-byte opcodestcg/i386/tcg-target.c+16 -61 reply
4/5tcg/i386: use movbe instruction in qemu_ldst routinestcg/i386/tcg-target.c+107 -451 reply
5/5tcg/i386: cleanup useless #ifdeftcg/i386/tcg-target.c+0 -21 reply

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by.

PatchRichard Henderson
1/5R-b
2/5R-b
3/5
4/5
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/5] tcg/i386: use movbe instruction in qemu_ldst routines

This patchset enable the usage of the movbe instruction, available on Intel Atom and Intel Haswell CPU, in qemu_ldst routines, avoiding bswap instructions before or after the store or loads. The availability of this instruction is done at runtime using the cpuid instruction.

The last patch of the series is not fully related, but I spotted the issue when working on this patchset, so I thought it's a good idea to fix it.

Aurelien Jarno (5):
disas/i386.c: disassemble movbe instruction tcg/i386: remove hardcoded P_REXW value tcg/i386: add support for three-byte opcodes tcg/i386: use movbe instruction in qemu_ldst routines tcg/i386: cleanup useless #ifdef

 disas/i386.c          |    8 +--
 tcg/i386/tcg-target.c |  178 ++++++++++++++++++++++++++++++++++---------------
 2 files changed, 128 insertions(+), 58 deletions(-)
Signature · 1 line
1.7.10.4