Skip to content

target-sh4: optimizations and cleanups

Aurelien Jarno qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 9 repliesIn review
  2. v18 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- rebased
- added last patch

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9target-sh4: use bit number for SR constantstarget-sh4/cpu.c target-sh4/cpu.h target-sh4/gdbstub.c +3 more+85 -801 reply
2/9target-sh4: Split out T from SRtarget-sh4/cpu.h target-sh4/gdbstub.c target-sh4/helper.c +2 more+110 -1471 reply
3/9target-sh4: optimize addc using add2target-sh4/translate.c+6 -81 reply
4/9target-sh4: optimize subc using sub2target-sh4/translate.c+6 -91 reply
5/9target-sh4: optimize negc using add2 and sub2target-sh4/translate.c+6 -61 reply
6/9target-sh4: split out Q and M from of SR and optimize div1target-sh4/cpu.h target-sh4/helper.h target-sh4/op_helper.c +1 more+68 -1311 reply
7/9target-sh4: factorize fmov implementationtarget-sh4/translate.c+6 -121 reply
8/9target-sh4: remove dead codetarget-sh4/translate.c+0 -11 reply
9/9target-sh4: simplify tas instructiontarget-sh4/translate.c+3 -71 reply

Reviews trailers per patch

8 of 9 patches have a Reviewed-by or Acked-by.

PatchRichard Henderson
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/9] target-sh4: optimizations and cleanups

This patchset improves the SH4 emulation by using the lately added TCG instructions, namely add2, sub2 and movcond. For that the T, Q and M bits are split out from the SR register.

The last three patches are doing cleanup in the code.

Changes v1 -> v2:
- rebased
- added last patch

Aurelien Jarno (9):
target-sh4: use bit number for SR constants
target-sh4: Split out T from SR
target-sh4: optimize addc using add2
target-sh4: optimize subc using sub2
target-sh4: optimize negc using add2 and sub2
target-sh4: split out Q and M from of SR and optimize div1
target-sh4: factorize fmov implementation
target-sh4: remove dead code
target-sh4: simplify tas instruction

 target-sh4/cpu.c       |    3 +-
 target-sh4/cpu.h       |   51 +++++---
 target-sh4/gdbstub.c   |    8 +-
 target-sh4/helper.c    |   29 ++---
 target-sh4/helper.h    |    1 -
 target-sh4/op_helper.c |  148 +----------------------
 target-sh4/translate.c |  313 ++++++++++++++++++++++++------------------------
 7 files changed, 221 insertions(+), 332 deletions(-)

--
1.7.10.4