Skip to content

virtio-net: backport error handling bugfix

Michael S. Tsirkin lkml netdev virtualization 2 versions – Applied

Status from this message: Queued up for -stable, thanks Michael.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 3 repliesApplied
  2. v12 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- include patch 3/3 as suggested by Michael
- tweak commit log as suggested by Jason

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3virtio_net: fix error handling for mergeable buffersdrivers/net/virtio_net.c+46 -201 reply
2/3virtio-net: make all RX paths handle errors consistentlydrivers/net/virtio_net.c+36 -201 reply
3/3virtio_net: don't leak memory or block when too many fragsdrivers/net/virtio_net.c+2 -10 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMichael DaltonJason Wang
1/3A-b A-b
2/3A-b A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH stable v2 0/3] virtio-net: backport error handling bugfix

Error handling for virtio-net mergeable buffers was broken for a long time. Backport recent bugfix to a stable kernel.

Please note that it's really a single change split out for ease of review - that's why 2/2 is here even though it's not stricktly a bugfix - the code becomes too confusing without it.

Please review and consider for stable.

Changes from v1:
- include patch 3/3 as suggested by Michael
- tweak commit log as suggested by Jason

Michael S. Tsirkin (3):
virtio_net: fix error handling for mergeable buffers
virtio-net: make all RX paths handle errors consistently
virtio_net: don't leak memory or block when too many frags

 drivers/net/virtio_net.c | 103 +++++++++++++++++++++++++++++++++--------------
 1 file changed, 73 insertions(+), 30 deletions(-)
Signature · 1 line
MST