Skip to content

acpi unit-test: rebuild aml files functionality

Marcel Apfelbaum qemu-devel 3 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 3 repliesIn review
  2. v22 patches 13 repliesSuperseded
  3. v12 patches 4 repliesSuperseded

Changes in v3 from the cover letter

Addressed Michael S. Tsirkin's comments:
- Used qemu_write_full instead of write
- Some trailing space

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2acpi unit-test: added script to rebuild the expected aml filestests/acpi-test-data/rebuild-expected-aml.sh+36 -00 replies
2/2acpi unit-test: hook to rebuild expected aml filestests/acpi-test.c+30 -73 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/2] acpi unit-test: rebuild aml files functionality

Acpi unit-test will fail every time the acpi tables change.

The series adds a script that rebuilds the expected aml files, so the test will pass. It also validates the modifications.

The acpi unit test will rebuild the aml tables if TEST_ACPI_REBUILD_AML environment variable is set.

v2 -> v3:
Addressed Michael S. Tsirkin's comments:
- Used qemu_write_full instead of write
- Some trailing space

v1 -> v2:
Addressed Michael S. Tsirkin's comments:
- added TEST_ prefix to the environment variable
- some rephrases

Marcel Apfelbaum (2):
acpi unit-test: added script to rebuild the expected aml files acpi unit-test: hook to rebuild expected aml files

 tests/acpi-test-data/rebuild-expected-aml.sh | 36 +++++++++++++++++++++++++++
 tests/acpi-test.c                            | 37 ++++++++++++++++++++++------
 2 files changed, 66 insertions(+), 7 deletions(-)
 create mode 100755 tests/acpi-test-data/rebuild-expected-aml.sh
Signature · 1 line
1.8.3.1