Skip to content

block: blk-mq: support blk_cleanup_queue on mq

Ming Lei lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 3 repliesIn review

Changes in v1 from the cover letter

- add patch 1/5
- add comments on blk_execute_rq_nowait 2/5
- set QUEUE_FLAG_DEAD for MQ 2/5
- use __blk_mq_drain_queue() helper 2/5

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5block: blk-mq: avoid initializing request during its completionblock/blk-mq.c+9 -172 replies
2/5block: blk-mq: support draining mq queueblock/blk-core.c block/blk-exec.c block/blk-mq.c +1 more+40 -180 replies
3/5block: blk-mq: make blk_sync_queue support mqblock/blk-core.c block/blk-mq.c+10 -20 replies
4/5block: null_blk: fix queue leak inside removing devicedrivers/block/null_blk.c+2 -81 reply
5/5block: blk-mq: don't export blk_mq_free_queue()block/blk-mq.c block/blk-mq.h block/blk-sysfs.c +1 more+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 0/5] block: blk-mq: support blk_cleanup_queue on mq

Hi,

The 1st one moves request initializtion out of completion handler.

The following 2 patches support drain/sync mq queue in blk_cleanup_queue.

The 4th patch calls blk_cleanup_queue() in removing device path to fix queue leak problem.

The 5th patch doesn't export blk_mq_free_queue() because the function is called in release handler of queue kobject, and drivers needn't to call it.

V1:
- add patch 1/5
- add comments on blk_execute_rq_nowait 2/5
- set QUEUE_FLAG_DEAD for MQ 2/5
- use __blk_mq_drain_queue() helper 2/5

 block/blk-core.c         |   21 ++++++++++++--
 block/blk-exec.c         |    4 +++
 block/blk-mq.c           |   71 +++++++++++++++++++++++-----------------------
 block/blk-mq.h           |    2 ++
 block/blk-sysfs.c        |    1 +
 drivers/block/null_blk.c |   10 ++-----
 include/linux/blk-mq.h   |    1 -
 7 files changed, 63 insertions(+), 47 deletions(-)

Thanks,
--
Ming Lei