Skip to content

acpi unit-test: new features

Marcel Apfelbaum qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7acpi unit-test: add test filestests/acpi-test-data/pc/APIC tests/acpi-test-data/pc/DSDT tests/acpi-test-data/pc/FACP +10 more+0 -00 replies
2/7configure: added acpi unit-test filesconfigure+4 -00 replies
3/7acpi unit-test: compare DSDT and SSDT tables against expected valuestests/acpi-test.c+240 -210 replies
4/7configure: add CONFIG_IASL to config-host.hscripts/create_config+4 -00 replies
5/7acpi unit-test: extract iasl executable from configurationtests/acpi-test.c+8 -230 replies
6/7acpi unit-test: added script to rebuild the expected aml filestests/acpi-test-data/rebuild-expected-aml.sh+36 -00 replies
7/7acpi unit-test: hook to rebuild expected aml filestests/acpi-test.c+25 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH resend 0/7] acpi unit-test: new features

This resend includes the following:

Compare resulting aml vs expected aml:
- runs only if iasl is installed on the host machine.
- the test plan:
1. Dumps the ACPI tables as AML on the disk.
2. Runs iasl to disassembly the tables into ASL files.
3. Runs iasl to disassembly the offline AML files.
3. Compares them with expected offline ASL files.
- the test runs for both default machine and q35.
- in case the test fails, it can be easily tweaked to show the differences between the ASL files and understand the issue.

Extract iasl executable from configuration:
- The test checked if iasl is installed by running "iasl" and checking the error output.
- It is better to use the iasl executable as appears in configuration.

Rebuild aml files functionality:
- Acpi unit-test will fail every time the acpi tables change.
- The series adds a script that rebuilds the expected aml files, so the test will pass. It also validates the modifications.
- The acpi unit test will rebuild the aml tables if TEST_ACPI_REBUILD_AML environment variable is set.

Marcel Apfelbaum (7):
acpi unit-test: add test files
configure: added acpi unit-test files
acpi unit-test: compare DSDT and SSDT tables against expected values
configure: add CONFIG_IASL to config-host.h
acpi unit-test: extract iasl executable from configuration acpi unit-test: added script to rebuild the expected aml files acpi unit-test: hook to rebuild expected aml files

 configure                                    |   4 +
 scripts/create_config                        |   4 +
 tests/acpi-test-data/pc/APIC                 | Bin 0 -> 120 bytes
 tests/acpi-test-data/pc/DSDT                 | Bin 0 -> 4407 bytes
 tests/acpi-test-data/pc/FACP                 | Bin 0 -> 116 bytes
 tests/acpi-test-data/pc/FACS                 | Bin 0 -> 64 bytes
 tests/acpi-test-data/pc/HPET                 | Bin 0 -> 56 bytes
 tests/acpi-test-data/pc/SSDT                 | Bin 0 -> 2104 bytes
 tests/acpi-test-data/q35/APIC                | Bin 0 -> 120 bytes
 tests/acpi-test-data/q35/DSDT                | Bin 0 -> 7344 bytes
 tests/acpi-test-data/q35/FACP                | Bin 0 -> 116 bytes
 tests/acpi-test-data/q35/FACS                | Bin 0 -> 64 bytes
 tests/acpi-test-data/q35/HPET                | Bin 0 -> 56 bytes
 tests/acpi-test-data/q35/MCFG                | Bin 0 -> 60 bytes
 tests/acpi-test-data/q35/SSDT                | Bin 0 -> 2104 bytes
 tests/acpi-test-data/rebuild-expected-aml.sh |  36 ++++
 tests/acpi-test.c                            | 266 ++++++++++++++++++++++++---
 17 files changed, 289 insertions(+), 21 deletions(-)
 create mode 100644 tests/acpi-test-data/pc/APIC
 create mode 100644 tests/acpi-test-data/pc/DSDT
 create mode 100644 tests/acpi-test-data/pc/FACP
 create mode 100644 tests/acpi-test-data/pc/FACS
 create mode 100644 tests/acpi-test-data/pc/HPET
 create mode 100644 tests/acpi-test-data/pc/SSDT
 create mode 100644 tests/acpi-test-data/q35/APIC
 create mode 100644 tests/acpi-test-data/q35/DSDT
 create mode 100644 tests/acpi-test-data/q35/FACP
 create mode 100644 tests/acpi-test-data/q35/FACS
 create mode 100644 tests/acpi-test-data/q35/HPET
 create mode 100644 tests/acpi-test-data/q35/MCFG
 create mode 100644 tests/acpi-test-data/q35/SSDT
 create mode 100755 tests/acpi-test-data/rebuild-expected-aml.sh
Signature · 1 line
1.8.3.1