Skip to content

w1: async netlink, search, fixes, and improvements

David Fries lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14w1: fix w1_send_slave dropping a slave iddrivers/w1/w1_netlink.c+13 -120 replies
2/14w1: fixup search to support abort from netlinkdrivers/w1/w1.c drivers/w1/w1.h drivers/w1/w1_int.c+13 -20 replies
3/14w1: Only wake up the search process if it is going to be searchingdrivers/w1/w1.c+3 -10 replies
4/14w1: increase w1_max_slave_count, allow write accessdrivers/w1/w1.c drivers/w1/w1.h+30 -20 replies
5/14w1: continue slave search where previous left offdrivers/w1/w1.c drivers/w1/w1.h+18 -30 replies
6/14w1: new netlink commands, add/remove/list slavesdrivers/w1/w1.c drivers/w1/w1.h drivers/w1/w1_netlink.c +1 more+126 -390 replies
7/14w1: process w1 netlink commands in w1_process threaddrivers/w1/w1.c drivers/w1/w1.h drivers/w1/w1_int.c +1 more+300 -950 replies
8/14connector: add portid to unicast in addition to broadcastingDocumentation/connector/cn_test.c drivers/connector/cn_proc.c drivers/connector/connector.c +6 more+37 -310 replies
9/14w1: reply only to the requester portiddrivers/w1/w1.h drivers/w1/w1_netlink.c+30 -170 replies
10/14w1: ds2490 reduce magic numbersdrivers/w1/masters/ds2490.c+15 -80 replies
11/14w1: ds2490 USB setup fixesdrivers/w1/masters/ds2490.c+14 -80 replies
12/14w1: ds2490 fix and enable hardware searchDocumentation/w1/masters/ds2490 drivers/w1/masters/ds2490.c+86 -240 replies
13/14w1: use family_data instead of rom in w1_slavedrivers/w1/slaves/w1_therm.c drivers/w1/w1.h+19 -30 replies
14/14w1: format for DocBook and fixesDocumentation/DocBook/Makefile Documentation/DocBook/w1.tmpl Documentation/w1/w1.netlink +7 more+315 -990 replies

Reviews trailers per patch

None of the 14 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEvgeniy Polyakov
SeriesA-b A-b
1/14
2/14
3/14
4/14
5/14
6/14
7/14
8/14
9/14
10/14
11/14
12/14
13/14
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/14] w1: async netlink, search, fixes, and improvements

This patch series aims to extend and improve the netlink interface to the one wire system. Netlink is exposed as a socket interface which is normally assumed to be asynchronous which only blocks waiting on incoming packets or a fulls end buffer, but were executed on the calling thread. A bus device search can be a lengthy operation and temperature conversion can take 750 ms. With this patch series those lengthy operations are now processed on the thread originally created to do automatic searching, which gives it a reason to exist when automatic search is disabled. Some other improvements for netlink is additional commands to add, remove, and list the known slaves, and send replies only to the requester. They were previously multicast to everyone listening on the group, this required an additional argument to cn_netlink_send.

Search improvements include returning all devices found, as the first that wouldn't fit in a packet would be lost. I marked only this patch for the stable tree, though you would have to have a lot of devices on one bus to hit it. I had a fix to support aborting from netlink rather than just avoiding the oops as the previous patch did. The search can now pick up where it left off, along with setting the maximum number of slaves to search for at a time, a large network could split up the search operation into multiple passes. ds2490 USB dongle now gains support for hardware search and along with not undoing the interface selection operation takes the search for my network from 23.16 seconds to .307346 seconds.

The largest single change is to change the comment style for DocBook to process in addition to comment some additional functions and data structures.