Skip to content

Enhance DMAR drivers to handle PCI/memory hotplug events

Jiang Liu linux-iommu linux-pci lkml 2 versions – Applied

Status from this message: Applied, thanks Jiang.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest17 patches 4 repliesApplied
  2. v114 patches 17 repliesSuperseded

Changes in v2 from the cover letter

1) fix more bugs in dealing with identify mapping domain
2) address round 1 review comments

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/17iommu/vt-d: avoid double free of g_iommus on error recovery pathdrivers/iommu/intel-iommu.c+10 -160 replies
2/17iommu/vt-d: avoid caching stale domain_device_info and fix memory leakdrivers/iommu/intel-iommu.c+2 -20 replies
3/17iommu/vt-d: avoid caching stale domain_device_info when hot-removing PCI devicedrivers/iommu/intel-iommu.c+9 -80 replies
4/17iommu/vt-d: factor out dmar_alloc_dev_scope() for later reusedrivers/iommu/dmar.c include/linux/dmar.h+17 -120 replies
5/17iommu/vt-d: move private structures and variables into intel-iommu.cdrivers/iommu/intel-iommu.c include/linux/dmar.h+26 -280 replies
6/17iommu/vt-d: simplify function get_domain_for_dev()drivers/iommu/intel-iommu.c+66 -760 replies
7/17iommu/vt-d: free resources if failed to create domain for PCIe endpointdrivers/iommu/intel-iommu.c+8 -70 replies
8/17iommu/vt-d: reduce duplicated code to handle virtual machine domainsdrivers/iommu/intel-iommu.c+45 -1320 replies
9/17iommu/vt-d: fix incorrect iommu_count for si_domaindrivers/iommu/intel-iommu.c+1 -10 replies
10/17iommu/vt-d: check for NULL pointer when freeing IOMMU data structuredrivers/iommu/intel-iommu.c+7 -00 replies
11/17iommu/vt-d: fix error in detect ATS capabilitydrivers/iommu/intel-iommu.c+17 -200 replies
12/17iommu/vt-d: introduce macro for_each_dev_scope() to walk device scope entriesdrivers/iommu/dmar.c drivers/iommu/intel-iommu.c include/linux/dmar.h+64 -560 replies
13/17iommu/vt-d: introduce a rwsem to protect global data structuresdrivers/iommu/dmar.c drivers/iommu/intel-iommu.c drivers/iommu/intel_irq_remapping.c +1 more+103 -480 replies
14/17iommu/vt-d: use RCU to protect global resources in interrupt contextdrivers/iommu/dmar.c drivers/iommu/intel-iommu.c include/linux/dmar.h+53 -230 replies
15/17iommu/vt-d, PCI: update DRHD/RMRR/ATSR device scope caches when PCI hotplug happensdrivers/iommu/dmar.c drivers/iommu/intel-iommu.c include/linux/dmar.h+283 -23 replies
16/17iommu/vt-d, PCI: unify the way to process DMAR device scope arraydrivers/iommu/dmar.c drivers/iommu/intel-iommu.c include/linux/dmar.h+61 -1780 replies
17/17iommu/vt-d: update IOMMU state when memory hotplug happensdrivers/iommu/intel-iommu.c drivers/iommu/iova.c include/linux/iova.h+130 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [Patch Part2 V2 00/17] Enhance DMAR drivers to handle PCI/memory hotplug events

Intel DMA/interrupt remapping drivers scan available PCI/memory devices at startup and cache discovered hardware topologies. They don't update cached information if PCI/memory hotplug event happens at runtime, then the stale information may break DMA/interrupt remapping logic.

This patchset first (Patch 1-12) tries to introduces some helper functions and fixes several bugs, then (Patch 13,14) uses a global rwsem and RCU to protect global DMA/interrupt remapping data structures, and finally (Patch 15-17) hook PCI/memory hotplug events to update cached information.

It's also a preparation for supporting of DMA/interrupt remapping hotplug.

V1->V2:
1) fix more bugs in dealing with identify mapping domain
2) address round 1 review comments

Jiang Liu (17):
iommu/vt-d: avoid double free of g_iommus on error recovery path iommu/vt-d: avoid caching stale domain_device_info and fix memory
leak
iommu/vt-d: avoid caching stale domain_device_info when hot-removing
PCI device
iommu/vt-d: factor out dmar_alloc_dev_scope() for later reuse iommu/vt-d: move private structures and variables into intel-iommu.c iommu/vt-d: simplify function get_domain_for_dev() iommu/vt-d: free resources if failed to create domain for PCIe
endpoint
iommu/vt-d: reduce duplicated code to handle virtual machine domains iommu/vt-d: fix incorrect iommu_count for si_domain iommu/vt-d: check for NULL pointer when freeing IOMMU data structure iommu/vt-d: fix error in detect ATS capability
iommu/vt-d: introduce macro for_each_dev_scope() to walk device scope
entries
iommu/vt-d: introduce a rwsem to protect global data structures iommu/vt-d: use RCU to protect global resources in interrupt context iommu/vt-d, PCI: update DRHD/RMRR/ATSR device scope caches when PCI
hotplug happens
iommu/vt-d, PCI: unify the way to process DMAR device scope array iommu/vt-d: update IOMMU state when memory hotplug happens

 drivers/iommu/dmar.c                |  412 +++++++++++++------
 drivers/iommu/intel-iommu.c         |  750 ++++++++++++++++++-----------------
 drivers/iommu/intel_irq_remapping.c |  108 +++--
 drivers/iommu/iova.c                |   64 ++-
 include/linux/dmar.h                |   74 ++--
 include/linux/iova.h                |    2 +
 6 files changed, 848 insertions(+), 562 deletions(-)
Signature · 1 line
1.7.10.4