Skip to content

RFC Export Minstrel best API information via get_station()

Antonio Quartulli batman linux-wireless 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5cfg80211: export minstrel best rate information through get_station()include/net/cfg80211.h+17 -08 replies
2/5mac80211: export minstrel best rate information in set_sta_info()include/net/mac80211.h net/mac80211/cfg.c+30 -01 reply
3/5mac80211: minstrel - implement get_minstrel_best_rate() APInet/mac80211/rc80211_minstrel.c+12 -00 replies
4/5mac80211: minstrel_ht - implement get_minstrel_best_rate() APInet/mac80211/rc80211_minstrel_ht.c+30 -00 replies
5/5cfg80211: implement cfg80211_get_stationinclude/net/cfg80211.h net/wireless/nl80211.c+33 -02 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/5] Export Minstrel best API information via get_station()

Hello list,

we (as batman-adv developers) are currently working on a new version of the our routing protocol which is going to use some Minstrel internal information to compute the metric.
In particular I am interested in the currently selected bitrate (which Minstrel selected because it "maximises the throughput") and it's probability of success.

To achieve so I am proposing here a change to the get_station API. This change is supposed to export the needed information only if the current driver is using the Minstrel (or Minstrel HT) RC algorithm.

Patch 1 introduced the change in get_station()
Patch 2 add a new rate_control API used to query the RC algorithm and retrieve
the information. Then it fills the sinfo object.
Patch 3 and 4 are implementing this rate_control API in minstrel and minstrel_ht Patch 5 exports the get_station API in order to allow other modules to use it.

I already had a discussion with Johannes about this patch being not generic enough and really focussed on Minstrel only.

However this change will just
introduce a new exported capability in the station_info object: if the driver does not support it (e.g. it does not use Minstrel) then we simply won't have this information (like we already do with other capabilities).

Cheers,

p.s. I may need to add some more kerneldoc

Antonio Quartulli (5):
cfg80211: export minstrel best rate information through get_station()
mac80211: export minstrel best rate information in set_sta_info()
mac80211: minstrel - implement get_minstrel_best_rate() API
mac80211: minstrel_ht - implement get_minstrel_best_rate() API
cfg80211: implement cfg80211_get_station

 include/net/cfg80211.h             | 28 ++++++++++++++++++++++++++++
 include/net/mac80211.h             | 15 +++++++++++++++
 net/mac80211/cfg.c                 | 15 +++++++++++++++
 net/mac80211/rc80211_minstrel.c    | 12 ++++++++++++
 net/mac80211/rc80211_minstrel_ht.c | 30 ++++++++++++++++++++++++++++++
 net/wireless/nl80211.c             | 22 ++++++++++++++++++++++
 6 files changed, 122 insertions(+)
Signature · 1 line
1.8.5.3