Skip to content

Introduce struct cycle to store cyclic region and clean up

Baoquan He kexec 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 1 replyIn review
  2. v23 patches 4 repliesSuperseded
  3. v13 patches 2 repliesSuperseded

Changes in v3 from the cover letter

Astushi and HATAYAMA found removing the pfn check in set_bitmap_cyclic will
introduce bugs. So it's better to add the pfn checking back, though there's a little influence on perforcemance.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3makedumpfile: introduce struct cycle to store the cyclic regionmakedumpfile.c makedumpfile.h+32 -00 replies
2/3makedumpfile: use struct cycle to update cyclic region and clean upmakedumpfile.c makedumpfile.h sadump_info.c+229 -2600 replies
3/3makedumpfile: remove member variables representing cyclic pfn region in struct DumpInfomakedumpfile.h+0 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [v3 0/3] Introduce struct cycle to store cyclic region and clean up

v1->v2:
In first_cycle(), start_pfn assignation is not aligned to info->pfn_cyclic. Now in v2 change this. Accordingly the pfn in write_elf_header() and write_elf_pages_cyclic() need be adjusted to the real beginning of a load segment, but not the cycle->start_pfn which may be lower after alignment.

v2->v3:
Astushi and HATAYAMA found removing the pfn check in set_bitmap_cyclic will
introduce bugs. So it's better to add the pfn checking back, though there's a little influence on perforcemance.

Baoquan He (3):
makedumpfile: introduce struct cycle to store the cyclic region
makedumpfile: use struct cycle to update cyclic region and clean up
makedumpfile: remove member variables representing cyclic pfn region
in struct DumpInfo

 makedumpfile.c | 498 ++++++++++++++++++++++++++++-----------------------------
 makedumpfile.h |  21 +--
 sadump_info.c  |   4 +-
 3 files changed, 261 insertions(+), 262 deletions(-)
Signature · 7 lines
1.8.3.1


_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec