Skip to content

drm/i915: vlv: handle only enabled pipestat interrupts

Imre Deak intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7drm/i915: vlv: don't unmask IIR[DISPLAY_PIPE_A/B_VBLANK] interruptdrivers/gpu/drm/i915/i915_irq.c+0 -141 reply
2/7drm/i915: factor out valleyview_pipestat_irq_handlerdrivers/gpu/drm/i915/i915_irq.c+42 -344 replies
3/7drm/i915: vlv: s/spin_lock_irqsave/spin_lock/ in irq handlerdrivers/gpu/drm/i915/i915_irq.c+2 -31 reply
4/7drm/i915: unify FLIP_DONE macro namesdrivers/gpu/drm/i915/i915_irq.c drivers/gpu/drm/i915/i915_reg.h+10 -101 reply
5/7drm/i915: pass status instead of enable flags to i915_enable_pipestatdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_irq.c drivers/gpu/drm/i915/i915_reg.h +1 more+53 -328 replies
6/7drm/i915: vlv: fix mapping of pipestat enable to status bitsdrivers/gpu/drm/i915/i915_irq.c drivers/gpu/drm/i915/i915_reg.h+38 -12 replies
7/7drm/i915: vlv: handle only enabled pipestat interrupt eventsdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_irq.c drivers/gpu/drm/i915/i915_reg.h+35 -32 replies

Reviews trailers per patch

5 of 7 patches have a Reviewed-by or Acked-by.

PatchJesse BarnesVille Syrjälä
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b R-b
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] drm/i915: vlv: handle only enabled pipestat interrupts

Atm on VLV we handle any pending pipestat interruts, whether or not these were actually enabled explicitly with i915_enable_pipestat(). This may or may not cause any real problem, but for consistency it's worth fixing. See the last patch for more details.

I also need this as a dependency for the VLV power domain support, since there we have to make sure we properly disable all pipestat interrupts during the power well is off.

I've already sent the first patch separate from this set, but I include it here since it's a dependency.

Tested on VLV with igt/kms_flip.

Imre Deak (7):
drm/i915: vlv: don't unmask IIR[DISPLAY_PIPE_A/B_VBLANK] interrupt drm/i915: factor out valleyview_pipestat_irq_handler drm/i915: vlv: s/spin_lock_irqsave/spin_lock/ in irq handler drm/i915: unify FLIP_DONE macro names
drm/i915: pass status instead of enable flags to i915_enable_pipestat drm/i915: vlv: fix mapping of pipestat enable to status bits drm/i915: vlv: handle only enabled pipestat interrupt events

 drivers/gpu/drm/i915/i915_drv.h |   7 +-
 drivers/gpu/drm/i915/i915_irq.c | 218 ++++++++++++++++++++++++++--------------
 drivers/gpu/drm/i915/i915_reg.h |  28 ++++--
 drivers/gpu/drm/i915/intel_tv.c |   8 +-
 4 files changed, 172 insertions(+), 89 deletions(-)
Signature · 1 line
1.8.4