drm/i915: vlv: handle only enabled pipestat interrupts
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 14 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | drm/i915: vlv: don't unmask IIR[DISPLAY_PIPE_A/B_VBLANK] interruptdrivers/ | +0 | 1 reply | |
| 2/7 | drm/i915: factor out valleyview_pipestat_irq_handlerdrivers/ | +42 | 4 replies | |
| 3/7 | drm/i915: vlv: s/spin_lock_irqsave/spin_lock/ in irq handlerdrivers/ | +2 | 1 reply | |
| 4/7 | drm/i915: unify FLIP_DONE macro namesdrivers/ drivers/ | +10 | 1 reply | |
| 5/7 | drm/i915: pass status instead of enable flags to i915_enable_pipestatdrivers/ drivers/ drivers/ +1 more | +53 | 8 replies | |
| 6/7 | drm/i915: vlv: fix mapping of pipestat enable to status bitsdrivers/ drivers/ | +38 | 2 replies | |
| 7/7 | drm/i915: vlv: handle only enabled pipestat interrupt eventsdrivers/ drivers/ drivers/ | +35 | 2 replies |
Reviews trailers per patch
5 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Jesse Barnes | Ville Syrjälä |
|---|---|---|
| 1/7 | R-b | |
| 2/7 | R-b | |
| 3/7 | R-b | |
| 4/7 | R-b | |
| 5/7 | R-b | R-b |
| 6/7 | ||
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/7] drm/i915: vlv: handle only enabled pipestat interrupts
Atm on VLV we handle any pending pipestat interruts, whether or not these were actually enabled explicitly with i915_enable_pipestat(). This may or may not cause any real problem, but for consistency it's worth fixing. See the last patch for more details.
I also need this as a dependency for the VLV power domain support, since there we have to make sure we properly disable all pipestat interrupts during the power well is off.
I've already sent the first patch separate from this set, but I include it here since it's a dependency.
Tested on VLV with igt/kms_flip.
Imre Deak (7):
drm/i915: vlv: don't unmask IIR[DISPLAY_PIPE_A/B_VBLANK] interrupt drm/i915: factor out valleyview_pipestat_irq_handler drm/i915: vlv: s/spin_lock_irqsave/spin_lock/ in irq handler drm/i915: unify FLIP_DONE macro names
drm/i915: pass status instead of enable flags to i915_enable_pipestat drm/i915: vlv: fix mapping of pipestat enable to status bits drm/i915: vlv: handle only enabled pipestat interrupt events
drivers/gpu/drm/i915/i915_drv.h | 7 +- drivers/gpu/drm/i915/i915_irq.c | 218 ++++++++++++++++++++++++++-------------- drivers/gpu/drm/i915/i915_reg.h | 28 ++++-- drivers/gpu/drm/i915/intel_tv.c | 8 +- 4 files changed, 172 insertions(+), 89 deletions(-)
Signature · 1 line
1.8.4