Skip to content

__btrfs_drop_extents() BUG_ON reproducer

David Disseldorp linux-btrfs linux-xfs 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 2 repliesIn review
  2. v23 patches 2 repliesSuperseded
  3. v12 patches 3 repliesSuperseded

Changes in v3 from the cover letter

- Remove explicit write error checks

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btrfs: add small program for clone testing.gitignore src/Makefile src/cloner.c+190 -10 replies
2/3src/cloner: use btrfs/ioctl.h header if presentconfigure.ac src/cloner.c+5 -00 replies
3/3btrfs/035: add new clone overwrite regression testtests/btrfs/035 tests/btrfs/035.out tests/btrfs/group+81 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/3] __btrfs_drop_extents() BUG_ON reproducer

This patch-set provides a reproducer for hitting the 3.14.0-rc1 BUG_ON() at:
692 int __btrfs_drop_extents(struct btrfs_trans_handle *trans,
...
839 /*

 840                  *  | ---- range to drop ----- |
 841                  *      | -------- extent -------- |
 842                  */

843 if (start <= key.offset && end < extent_end) {
844 BUG_ON(extent_type == BTRFS_FILE_EXTENT_INLINE);
845
846 memcpy(&new_key, &key, sizeof(new_key));

The first patch adds a small cloner binary which is used by btrfs/035 to dispatch BTRFS_IOC_CLONE_RANGE requests.

This workload resembles that of Samba's vfs_btrfs module, when a Windows client restores a file from a shadow-copy (snapshot) using server-side copy requests.

Changes since V2:
- Remove explicit write error checks

Changes since V1:
- Use strtoull instead of atoi
- Print error conditions in cloner
- Check for cloner binary before running test
- Continue test on failure
- Add cloner to .gitignore

Feedback appreciated.

Cheers, David

 .gitignore          |   1 +
 configure.ac        |   1 +
 src/Makefile        |   2 +-
 src/cloner.c        | 192 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/btrfs/035     |  77 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/btrfs/035.out |   3 +++
 tests/btrfs/group   |   1 +
 7 files changed, 276 insertions(+), 1 deletion(-)