Skip to content

Smatch warning fixups

Lucas Stach barebox 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14remove redundant NULL check on freecommon/environment.c drivers/eeprom/at25.c drivers/usb/core/usb.c +2 more+5 -90 replies
2/14commands: edit: properly propagate error codecommands/edit.c+1 -10 replies
3/14common: env: properly propagate error codecommon/environment.c+1 -10 replies
4/14clk: imx: unsigned mfn is never less than zeroarch/arm/mach-imx/clk-pllv1.c+0 -20 replies
5/14lib: math: fix return path (numstack may be NULL)lib/math.c+2 -20 replies
6/14lib: libbb: f should never be NULLlib/libbb.c+1 -10 replies
7/14comamnds: uimage: actually print error messagecommands/uimage.c+1 -11 reply
8/14usb: ulpi: fix logic-opdrivers/usb/otg/ulpi.c+2 -20 replies
9/14usb: dfu: fix error path to avoid NULL ptr derefdrivers/usb/gadget/dfu.c+3 -10 replies
10/14net: usb: smsc95xx: fix wrong phy reset conditiondrivers/net/usb/smsc95xx.c+1 -10 replies
11/14net: usb: asix: properly propagate error codedrivers/net/usb/asix.c+2 -20 replies
12/14mtd: core: avoid possible NULL ptr derefdrivers/mtd/core.c+2 -10 replies
13/14clk: avoid possible NULL ptr derefdrivers/clk/clkdev.c+5 -30 replies
14/14don't cast negative error codes to unsigned size_tcommon/uimage.c include/image.h+4 -41 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/14] Smatch warning fixups

I've run smatch over a imx_v7_defconfig build and fixed the resulting warnings.

Some of them are just minor issues with no real impact, but some of them are real potential problems or even real bugs.

Lucas Stach (14):
remove redundant NULL check on free
commands: edit: properly propagate error code
common: env: properly propagate error code
clk: imx: unsigned mfn is never less than zero
lib: math: fix return path (numstack may be NULL)
lib: libbb: f should never be NULL
comamnds: uimage: actually print error message
usb: ulpi: fix logic-op
usb: dfu: fix error path to avoid NULL ptr deref
net: usb: smsc95xx: fix wrong phy reset condition
net: usb: asix: properly propagate error code
mtd: core: avoid possible NULL ptr deref
clk: avoid possible NULL ptr deref
don't cast negative error codes to unsigned size_t

 arch/arm/mach-imx/clk-pllv1.c | 2 --
 commands/edit.c               | 2 +-
 commands/uimage.c             | 2 +-
 common/environment.c          | 5 ++---
 common/uimage.c               | 6 +++---
 drivers/clk/clkdev.c          | 8 +++++---
 drivers/eeprom/at25.c         | 3 +--
 drivers/mtd/core.c            | 3 ++-
 drivers/net/usb/asix.c        | 4 ++--
 drivers/net/usb/smsc95xx.c    | 2 +-
 drivers/usb/core/usb.c        | 3 +--
 drivers/usb/gadget/dfu.c      | 4 +++-
 drivers/usb/otg/ulpi.c        | 4 ++--
 include/image.h               | 2 +-
 lib/libbb.c                   | 2 +-
 lib/math.c                    | 4 ++--
 lib/parameter.c               | 3 +--
 net/eth.c                     | 2 +-
 18 files changed, 30 insertions(+), 31 deletions(-)
Signature · 7 lines
1.8.5.3


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox