Skip to content

drm/i915: dp: fix order of dp aux i2c device cleanup

Imre Deak intel-gfx 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 2 repliesIn review
  2. v13 patches 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/i915: add unregister callback to connectordrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_crt.c drivers/gpu/drm/i915/intel_display.c +8 more+29 -20 replies
2/4drm/i915: dp: fix order of dp aux i2c device cleanupdrivers/gpu/drm/i915/intel_dp.c+22 -20 replies
3/4drm/i915: sdvo: fix error path in sdvo_connector_initdrivers/gpu/drm/i915/intel_sdvo.c+39 -100 replies
4/4drm/i915: sdvo: add i2c sysfs symlink to the connector's directorydrivers/gpu/drm/i915/intel_sdvo.c+23 -10 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAntti Koskipää
SeriesR-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] drm/i915: dp: fix order of dp aux i2c device cleanup

The main point of this patchset is to fix a driver unload bug caused by incorrect order of dp aux i2c cleanup wrt. destroying the corresponding encoder/connector objects, see the second patch for details.

Tested on vlv/dp.

v2: move all sysfs removal bits to the new connector->unregister
callback (Daniel)

Imre Deak (4):
drm/i915: add unregister callback to connector drm/i915: dp: fix order of dp aux i2c device cleanup drm/i915: sdvo: fix error path in sdvo_connector_init drm/i915: sdvo: add i2c sysfs symlink to the connector's directory

 drivers/gpu/drm/i915/i915_drv.h      |  1 +
 drivers/gpu/drm/i915/intel_crt.c     |  1 +
 drivers/gpu/drm/i915/intel_display.c | 14 ++++++--
 drivers/gpu/drm/i915/intel_dp.c      | 23 +++++++++++-
 drivers/gpu/drm/i915/intel_drv.h     |  8 +++++
 drivers/gpu/drm/i915/intel_dsi.c     |  1 +
 drivers/gpu/drm/i915/intel_dvo.c     |  1 +
 drivers/gpu/drm/i915/intel_hdmi.c    |  1 +
 drivers/gpu/drm/i915/intel_lvds.c    |  1 +
 drivers/gpu/drm/i915/intel_sdvo.c    | 70 +++++++++++++++++++++++++++++++-----
 drivers/gpu/drm/i915/intel_tv.c      |  1 +
 11 files changed, 110 insertions(+), 12 deletions(-)
Signature · 1 line
1.8.4