tipc: clean up media and bearer layer
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest posting 2/214 patches 1 replyIn review
- v2 posting 1/20 of 14 patches 0 repliesSuperseded
- v114 patches 1 replySuperseded
Changes in v2 from the cover letter
- Re-inserted a removed kerneldoc entry in commit#5, based on feedback from D. Miller.
Patches in v2 posting 2/2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | tipc: stricter behavior of message reassembly functionnet/ net/ net/ | +15 | 0 replies | |
| 2/14 | tipc: move code for resetting links from bearer.c to link.cnet/ net/ net/ | +14 | 0 replies | |
| 3/14 | tipc: move code for deleting links from bearer.c to link.cnet/ net/ net/ | +11 | 0 replies | |
| 4/14 | tipc: redefine 'started' flag in struct link to bitmapnet/ net/ | +13 | 0 replies | |
| 5/14 | tipc: remove 'links' list from tipc_bearer structnet/ net/ net/ +2 more | +30 | 0 replies | |
| 6/14 | tipc: change reception of tunnelled duplicate packetsnet/ | +32 | 0 replies | |
| 7/14 | tipc: change reception of tunnelled failover packetsnet/ | +47 | 0 replies | |
| 8/14 | tipc: change signature of tunnelling reception functionnet/ | +4 | 0 replies | |
| 9/14 | tipc: more cleanup of tunnelling reception functionnet/ | +7 | 0 replies | |
| 10/14 | tipc: rename stack variables in function tipc_link_tunnel_rcvnet/ | +11 | 0 replies | |
| 11/14 | tipc: changes to general packet reception algorithmnet/ | +40 | 0 replies | |
| 12/14 | tipc: delay delete of link when failover is needednet/ net/ net/ +1 more | +36 | 0 replies | |
| 13/14 | tipc: remove bearer_lock from tipc_bearer structnet/ net/ net/ | +4 | 0 replies | |
| 14/14 | tipc: add node_lock protection to link lookup functionnet/ | +65 | 0 replies |
Reviews trailers per patch
11 of 14 patches have a Reviewed-by or Acked-by.
| Patch | Paul Gortmaker | Ying Xue |
|---|---|---|
| 1/14 | R-b | |
| 2/14 | R-b | |
| 3/14 | R-b | |
| 4/14 | R-b | |
| 5/14 | R-b | |
| 6/14 | ||
| 7/14 | R-b | |
| 8/14 | R-b | |
| 9/14 | ||
| 10/14 | ||
| 11/14 | R-b | |
| 12/14 | R-b | |
| 13/14 | R-b | |
| 14/14 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v2 00/14] tipc: clean up media and bearer layer
This commit series aims at facilitating future changes to the locking policy around nodes, links and bearers.
Currently, we have a big read/write lock (net_lock) that is used for serializing all changes to the node, link and bearer lists, as well as to their mutual pointers and references.
But, in order to allow for concurrent access to the contents of these structures, net_lock is only used in read mode by the data path code, and hence a finer granular locking policy must be applied inside the scope of net_lock: a spinlock (node_lock) for each node structure, and another one (bearer_lock) for protection of bearer structures.
This locking policy has proved hard to maintain. We have several times encountered contention problems between node_lock and bearer_lock, and with the advent of the RCU locking mechanism we feel it is anyway obsolete and ripe for improvements.
We now plan to replace net_lock with an RCU lock, as well as getting rid of bearer_lock altogether. This will both reduce data path overhead and make the code more manageable, while reducing the risk of future lock contention problems.
Prior to these changes, we need to do some necessary cleanup and code consolidation. This is what we do with this commit series, before we finally remove bearer_lock. In a later series we will replace net_lock with an RCU lock.
v2:
- Re-inserted a removed kerneldoc entry in commit#5, based on feedback from D. Miller.
Jon Maloy (9):
tipc: stricter behavior of message reassembly function
tipc: change reception of tunnelled duplicate packets
tipc: change reception of tunnelled failover packets
tipc: change signature of tunnelling reception function
tipc: more cleanup of tunnelling reception function
tipc: rename stack variables in function tipc_link_tunnel_rcv
tipc: changes to general packet reception algorithm
tipc: delay delete of link when failover is needed
tipc: add node_lock protection to link lookup function
Ying Xue (5):
tipc: move code for resetting links from bearer.c to link.c
tipc: move code for deleting links from bearer.c to link.c
tipc: redefine 'started' flag in struct link to bitmap
tipc: remove 'links' list from tipc_bearer struct
tipc: remove bearer_lock from tipc_bearer struct
net/tipc/bcast.c | 7 +- net/tipc/bearer.c | 42 ++---- net/tipc/bearer.h | 7 +- net/tipc/core.c | 2 +- net/tipc/link.c | 432 ++++++++++++++++++++++++++++++----------------------- net/tipc/link.h | 34 ++--- net/tipc/node.c | 8 +- 7 files changed, 283 insertions(+), 249 deletions(-)
Signature · 1 line
1.7.9.5