Skip to content

RFC Move RTC interrupt injection back into the vpt code.

Tim Deegan xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3x86/hvm/rtc: Don't run the vpt timer when !REG_B.PIE.xen/arch/x86/hvm/rtc.c xen/include/asm-x86/hvm/vpt.h+43 -122 replies
2/3x86/hvm/rtc: Inject RTC periodic interupts from the vpt code.xen/arch/x86/hvm/rtc.c xen/arch/x86/hvm/vpt.c xen/include/asm-x86/hvm/vpt.h+11 -551 reply
3/3x86/hvm/rtc: Always deassert the IRQ line when clearing REG_C.IRQF.xen/arch/x86/hvm/rtc.c+1 -12 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH RFC 0/3] Move RTC interrupt injection back into the vpt code.

Hi,

This series implements the most recent idea I was proposing about reworking the RTC PF interrupt injection.

Patch 1 switches handling the !PIE case to calculate the right answer for REG_C.PF on demand rather than running the timers. Patch 2 switches back to the old model of having the vpt code control the timer interrupt injection; this is the fix for the w2k3 hang. Patch 3 is just a minor cleanup, and not particularly necessary.

N.B. In its current state it DOES NOT WORK. I got distracted by other things today and didn't get a chance to finish working on it, but I wanted to send it out for feedback on the general approach. If it seems broadly acceptable then either I can pick it up again next week or maybe Andrew can look at fixing it.

Cheers,

Tim.