Good bye fnmatch
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | Use wildmatch() directly without fnmatch() wrapperbuiltin/ builtin/ builtin/ +11 more | +20 | 0 replies | |
| 2/4 | Revert "test-wildmatch: add "perf" command to compare wildmatch and fnmatch"test-wildmatch.c | +0 | 0 replies | |
| 3/4 | Stop using fnmatch (either native or compat)Makefile config.mak.uname configure.ac +3 more | +0 | 0 replies | |
| 4/4 | Actually remove compat fnmatch source codecompat/ compat/ | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] Good bye fnmatch
Long story short, we wanted globbing wildcard "**" so I ripped wildmatch library from rsync to do it. And it opened a possibility to replace fnmatch completely, which would provide consistent behavior across platforms (native fnmatch behaves differently on many corner cases), and some performance gains. I started fnmatch replacement with 4917e1e (Makefile: promote wildmatch to be the default fnmatch implementation - 2013-05-30). This is the final step.
Nguyễn Thái Ngọc Duy (4):
Use wildmatch() directly without fnmatch() wrapper
Revert "test-wildmatch: add "perf" command to compare wildmatch and fnmatch" Stop using fnmatch (either native or compat)
Actually remove compat fnmatch source code
Makefile | 22 -- builtin/apply.c | 2 +- builtin/branch.c | 2 +- builtin/describe.c | 2 +- builtin/for-each-ref.c | 2 +- builtin/ls-remote.c | 2 +- builtin/name-rev.c | 2 +- builtin/reflog.c | 2 +- builtin/replace.c | 2 +- builtin/show-branch.c | 2 +- builtin/tag.c | 2 +- compat/fnmatch/fnmatch.c (gone) | 494 ---------------------------------------- compat/fnmatch/fnmatch.h (gone) | 84 ------- config.mak.uname | 10 - configure.ac | 28 --- diffcore-order.c | 2 +- dir.c | 11 +- git-compat-util.h | 12 - refs.c | 2 +- revision.c | 2 +- t/t3070-wildmatch.sh | 13 -- test-wildmatch.c | 79 ------- 22 files changed, 20 insertions(+), 759 deletions(-)
Signature · 1 line
1.8.5.2.240.g8478abd