Skip to content

qemu-img: Fix handling of multiply specified options

Kevin Wolf qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7qemu-img create: Detect options specified more than onceqemu-img.c+29 -32 replies
2/7qemu-img convert: Detect options specified more than onceqemu-img.c+45 -40 replies
3/7qemu-img amend: Detect options specified more than onceqemu-img.c+16 -20 replies
4/7qemu-img: Detect options specified more than onceqemu-img.c+65 -10 replies
5/7qemu-img create: Support multiple -o optionsqemu-img.c+12 -92 replies
6/7qemu-img convert: Support multiple -o optionsqemu-img.c+26 -180 replies
7/7qemu-img amend: Support multiple -o optionsqemu-img.c+6 -60 replies

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by.

PatchFam Zheng
1/7R-b
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/7] qemu-img: Fix handling of multiply specified options

If you specify the same option more than once (e.g. -o cluster_size=4k -o lazy_refcounts=on), qemu-img silently ignores all but the last one. This series fixes it to either consider all options or to give an error message.

Boolean option can still be given more than once as they aren't problematic in this respect (ten times -q is still quiet).

Kevin Wolf (7):
qemu-img create: Detect options specified more than once qemu-img convert: Detect options specified more than once qemu-img amend: Detect options specified more than once
qemu-img: Detect options specified more than once qemu-img create: Support multiple -o options qemu-img convert: Support multiple -o options qemu-img amend: Support multiple -o options

 qemu-img.c | 198 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 177 insertions(+), 21 deletions(-)
Signature · 1 line
1.8.1.4