Skip to content

vfio: blacklist loading of unstable roms

Bandan Das qemu-devel 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 1 replyApplied
  2. v32 patches 3 repliesSuperseded
  3. v22 patches 13 repliesSuperseded

Changes in v4 from the cover letter

1. Short Description of the issue in comments, pointer to qemu bug tracker in 2/2
2. Remove unnecessary check on rom_bar in vfio_pci_size_rom 2/2
3. No changes to 1/2 - Andreas, I have retained your "Reviewed-by" since the code hasn't changed.

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/2qdev-monitor: set DeviceState opts before calling realizeqdev-monitor.c+3 -10 replies
2/2vfio: blacklist loading of unstable romshw/misc/vfio.c+73 -00 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchAndreas Färber
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Qemu-devel] [PATCH 0/2 v4] vfio: blacklist loading of unstable roms

v4:
1. Short Description of the issue in comments, pointer to qemu bug tracker in 2/2
2. Remove unnecessary check on rom_bar in vfio_pci_size_rom 2/2
3. No changes to 1/2 - Andreas, I have retained your "Reviewed-by" since the code hasn't changed.

v3:
1. Change the "force" logic to depend on whether the user specified rombar, eliminate dependence on multiple values of rom_bar
2. Avoid printing the informational message if there's no rom
3. Minor changes to commit messages

v2:
1. Break up into two patches separating the infrastructural changes
2. Change vendor_id and device_id type to uint16_t
3. Rename struct for blacklisted devid and vendorid to more meaningful names
4. Remove unnecessary rom_quirk variable and just call vfio_blacklist_opt_rom() in vfio_pci_size_rom()

Bandan Das (2):
qdev-monitor: set DeviceState opts before calling realize
vfio: blacklist loading of unstable roms

 hw/misc/vfio.c | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 qdev-monitor.c |  4 +++-
 2 files changed, 76 insertions(+), 1 deletion(-)
Signature · 1 line
1.8.3.1