Skip to content

perf tools: Update on filtered entries' percentage output (v5)

Namhyung Kim lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8perf tools: Count periods of filtered entries separatelytools/perf/builtin-report.c tools/perf/util/event.c tools/perf/util/hist.c +2 more+24 -220 replies
2/8perf hists: Add support for showing relative percentagetools/perf/builtin-report.c tools/perf/util/hist.c tools/perf/util/hist.h+23 -40 replies
3/8perf report: Add --percentage optiontools/perf/Documentation/perf-report.txt tools/perf/builtin-report.c tools/perf/ui/browsers/hists.c +6 more+109 -490 replies
4/8perf top: Add --percentage optiontools/perf/Documentation/perf-top.txt tools/perf/builtin-report.c tools/perf/builtin-top.c +2 more+36 -180 replies
5/8perf diff: Add --percentage optiontools/perf/Documentation/perf-diff.txt tools/perf/builtin-diff.c+45 -90 replies
6/8perf tools: Add hist.percentage config optiontools/perf/builtin-diff.c tools/perf/util/config.c tools/perf/util/hist.c +1 more+15 -00 replies
7/8perf ui/tui: Add 'F' hotkey to toggle percentage outputtools/perf/ui/browsers/hists.c+4 -00 replies
8/8perf tools: Show absolute percentage by defaulttools/perf/util/symbol.c+0 -10 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJiri Olsa
SeriesA-b
1/8
2/8
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCHSET 0/8] perf tools: Update on filtered entries' percentage output (v5)

Hello,

I added --percentage option to perf report to control display of percentage of filtered entries.

usage: perf report [<options>]

--percentage <relative|absolute>
how to display percentage of filtered entries

"relative" means it's relative to filtered entries only so that the sum of shown entries will be always 100%. "absolute" means it retains original value before and after the filter applied. In patch 8/8, I made the "absolute" as default since it makes more sense IMHO.

      $ perf report -s comm
      # Overhead       Command
      # ........  ............
      #
          74.19%           cc1
           7.61%           gcc
           6.11%            as
           4.35%            sh
           4.14%          make
           1.13%        fixdep
      ...
      $ perf report -s comm -c cc1,gcc --percentage absolute
      # Overhead       Command
      # ........  ............
      #
          74.19%           cc1
           7.61%           gcc
      $ perf report -s comm -c cc1,gcc --percentage relative
      # Overhead       Command
      # ........  ............
      #
          90.69%           cc1
           9.31%           gcc

Note that it has zero effect if no filter was applied.

* changes in v5:
- fix 0 samples in relative percent output (Jiri)
- factor hists__total_period function (Jiri)
- share config parsing code with option parser (Jiri)

* changes in v4:
- support perf top and perf diff also (Jiri)
- add HIST_FILTER__HOST/GUEST (Jiri)
- retain both of filtered and total stats (Arnaldo)
- add 'F' hotkey on TUI (Jiri)
- rename config variable to have "hist." prefix

You can get this on the 'perf/percentage-v5' branch in my tree

git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Any comments are welcome, thanks
Namhyung

Namhyung Kim (8):
perf tools: Count periods of filtered entries separately perf hists: Add support for showing relative percentage perf report: Add --percentage option
perf top: Add --percentage option
perf diff: Add --percentage option
perf tools: Add hist.percentage config option perf ui/tui: Add 'F' hotkey to toggle percentage output perf tools: Show absolute percentage by default

 tools/perf/Documentation/perf-diff.txt   | 21 +++++++++--
 tools/perf/Documentation/perf-report.txt | 24 +++++++++---
 tools/perf/Documentation/perf-top.txt    | 18 +++++++--
 tools/perf/builtin-diff.c                | 35 ++++++++++++++---
 tools/perf/builtin-report.c              | 24 ++++++++++--
 tools/perf/builtin-top.c                 |  2 +
 tools/perf/ui/browsers/hists.c           | 47 +++++++++++++++++------
 tools/perf/ui/gtk/hists.c                | 19 +++++-----
 tools/perf/ui/hist.c                     |  8 ++--
 tools/perf/util/config.c                 |  4 ++
 tools/perf/util/event.c                  | 22 +++++------
 tools/perf/util/hist.c                   | 65 +++++++++++++++++++++-----------
 tools/perf/util/hist.h                   | 19 ++++++++++
 tools/perf/util/symbol.h                 |  5 ++-
 14 files changed, 233 insertions(+), 80 deletions(-)
Signature · 1 line
1.7.11.7