Skip to content

ixgbe, fix numa issues

Prarit Bhargava netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ixgbe, make interrupt allocations NUMA awaredrivers/net/ethernet/intel/ixgbe/ixgbe.h drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +1 more+33 -83 replies
2/2ixgbe, don't assume mapping of numa node cpusdrivers/net/ethernet/intel/ixgbe/ixgbe_lib.c+9 -73 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] ixgbe, fix numa issues

The ixgbe driver makes some assumptions about the layout of cpus in the system which are not always correct given a particular system layout. The ixgbe driver allocates one MSI/cpu for queue usage but the code does not take into account that devices are located on NUMA nodes and that the cpus in a node are not contiguous.

These issues were found while doing cpu hotplug testing, however, both of these issues can lead to obvious system performance issues as they defeat the purpose of having one MSI processing a queue per cpu.

Cc Jeff Kirsher <[email protected]>
Cc Jesse Brandeburg <[email protected]>
Cc Bruce Allan <[email protected]>
Cc Carolyn Wyborny <[email protected]>
Cc Don Skidmore <[email protected]>
Cc Greg Rose <[email protected]>
Cc Alex Duyck <[email protected]>
Cc John Ronciak <[email protected]>
Cc Mitch Williams <[email protected]>
Cc "David S. Miller" <[email protected]>

Prarit Bhargava (2):
ixgbe, make interrupt allocations NUMA aware
ixgbe, don't assume mapping of numa node cpus

 drivers/net/ethernet/intel/ixgbe/ixgbe.h       |    2 ++
 drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c   |   44 ++++++++++++++++++------
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c  |    6 ++--
 drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c |    5 +--
 4 files changed, 42 insertions(+), 15 deletions(-)
Signature · 14 lines
1.7.9.3


------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired