Skip to content

timer: move APIs together according to their category

Xuebing Wang qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7timer: move QEMUTimerList functions togetherinclude/qemu/timer.h qemu-timer.c+129 -1300 replies
2/7timer: make QEMUTimerList functions private (remove from APIs)include/qemu/timer.h qemu-timer.c+87 -1040 replies
3/7timer: move QEMUClockType related functions togetherqemu-timer.c+82 -780 replies
4/7timer: move QEMUTimerListGroup function to be below QEMUClockTypeqemu-timer.c+45 -410 replies
5/7timer: move QEMUTimer related functions togetherqemu-timer.c+8 -50 replies
6/7timer: move general utility functions togetherqemu-timer.c+50 -470 replies
7/7timer: clean unnecessary #include and use minimal required #includeqemu-timer.c+3 -60 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAlex Bligh
SeriesR-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/7] timer: move APIs together according to their category

There are 6 categories of APIs:
- QEMUClockType
- QEMUTimerList
- QEMUTimerListGroup
- QEMUTimer
- General utility functions
- Low level clock functions

Problems / solutions with previous API implementations:
1) Can not think of cases that we need QEMUTimerList APIs.
Reference: kernel_tree/Documentation/SubmittingPatches
-- Section "4) Don't over-design"
Purpose: simplify API
Solution: remove them from APIs
2) Implementations of some APIs are interwined
Purpose: put them together according to their categories, thus new
engineers are easy to understand them
Solution: put them together
3) Unnecessary header files are included
Purpose: simplify the included header files
Solution: only include the minimally required header file

This patchset includes below changes:
- put QEMUTimerList related functions together and make them private
- put QEMUClockType related functions together
- move QEMUTimerListGroup function to be below QEMUClockType
- put QEMUTimer related functions together
- put general utility functions together
- clean unnecessary #include and use minimal required #include

Xuebing Wang (7):
timer: move QEMUTimerList functions together
timer: make QEMUTimerList functions private (remove from APIs)
timer: move QEMUClockType related functions together
timer: move QEMUTimerListGroup function to be below QEMUClockType
timer: move QEMUTimer related functions together
timer: move general utility functions together
timer: clean unnecessary #include and use minimal required #include

 include/qemu/timer.h |   94 --------
 qemu-timer.c         |  595 +++++++++++++++++++++++++++++---------------------
 2 files changed, 341 insertions(+), 348 deletions(-)
Signature · 1 line
1.7.9.5