Skip to content

bnx2x: minimize RAM usage in kdump

Michal Schmidt netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3bnx2x: clamp num_queues to prevent passing a negative valuedrivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c+3 -40 replies
2/3bnx2x: save RAM in kdump kernel by using a single queuedrivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c+5 -00 replies
3/3bnx2x: save RAM in kdump kernel by disabling TPAdrivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c+2 -00 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAriel Elior
SeriesA-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/3] bnx2x: minimize RAM usage in kdump

kdump kernels usually have only a small amount of memory reserved. bnx2x can be memory-hungry. Let's minimize its memory usage when running in kdump.

I detect kdump by looking at the "reset_devices" flag. A couple of storage drivers (cciss, hpsa) use it for the same purpose. I am not sure this is the best way to solve the problem, but it works.

Should it be made more generic by, say, looking at the total amount of lowmem instead? Not using TPA by default when lowmem is small and/or defaulting to fewer queues would help 32bit systems where a driver for a multi-function multi-queue NIC can consume a significant amount of available memory. Or do we want no such heuristics?

Is this something to consider doing for other network drivers too?

Michal Schmidt (3):
bnx2x: clamp num_queues to prevent passing a negative value
bnx2x: save RAM in kdump kernel by using a single queue
bnx2x: save RAM in kdump kernel by disabling TPA

 drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c  | 12 ++++++++----
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c |  2 ++
 2 files changed, 10 insertions(+), 4 deletions(-)
Signature · 1 line
1.8.5.3