Skip to content

Merge PC8 with runtime PM, v2

Paulo Zanoni intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest23 patches 31 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23drm/i915: Accurately track when we mark the hardware as idle/busydrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/intel_display.c+22 -90 replies
2/23drm/i915: put runtime PM only at the end of intel_mark_idledrivers/gpu/drm/i915/intel_display.c+4 -30 replies
3/23drm/i915: put runtime PM only when we actually release force_wakedrivers/gpu/drm/i915/intel_uncore.c+11 -30 replies
4/23drm/i915: kill dev_priv->pc8.gpu_idledrivers/gpu/drm/i915/i915_debugfs.c drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_display.c +1 more+8 -371 reply
5/23drm/i915: rename modeset_update_power_wellsdrivers/gpu/drm/i915/intel_display.c+2 -20 replies
6/23drm/i915: get/put runtime PM without holding rps.hw_lockdrivers/gpu/drm/i915/i915_debugfs.c+7 -50 replies
7/23drm/i915: add forcewake functions that don't touch runtime PMdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_uncore.c+44 -04 replies
8/23drm/i915: extract __hsw_do_{en, dis}able_package_c8drivers/gpu/drm/i915/intel_display.c+38 -260 replies
9/23drm/i915: make PC8 be part of runtime PM suspend/resumedrivers/gpu/drm/i915/i915_dma.c drivers/gpu/drm/i915/i915_drv.c drivers/gpu/drm/i915/i915_drv.h +4 more+23 -512 replies
10/23drm/i915: get/put runtime PM when we get/put a power domaindrivers/gpu/drm/i915/intel_pm.c+4 -02 replies
11/23drm/i915: remove dev_priv->pc8.requirements_metdrivers/gpu/drm/i915/i915_debugfs.c drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_display.c +1 more+3 -590 replies
12/23drm/i915: get runtime PM references when the GPU is idle/busydrivers/gpu/drm/i915/intel_display.c+2 -21 reply
13/23drm/i915: kill pc8.disable_countdrivers/gpu/drm/i915/i915_debugfs.c drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_display.c +1 more+0 -171 reply
14/23drm/i915: remove an indirection level on PC8 functionsdrivers/gpu/drm/i915/intel_display.c+2 -141 reply
15/23drm/i915: don't get/put PC8 reference on freeze/thawdrivers/gpu/drm/i915/i915_drv.c+0 -51 reply
16/23drm/i915: get/put runtime PM references for GMBUS and DP AUXdrivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_drv.h drivers/gpu/drm/i915/intel_i2c.c +1 more+4 -176 replies
17/23drm/i915: don't get/put PC8 when getting/putting power wellsdrivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_drv.h drivers/gpu/drm/i915/intel_pm.c+2 -321 reply
18/23drm/i915: remove dev_priv->pc8.enableddrivers/gpu/drm/i915/i915_debugfs.c drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_display.c +1 more+0 -91 reply
19/23drm/i915: move pc8.irqs_disabled to pm.irqs_disableddrivers/gpu/drm/i915/i915_debugfs.c drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem.c +4 more+42 -412 replies
20/23drm/i915: kill struct i915_package_c8drivers/gpu/drm/i915/i915_debugfs.c drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_pm.c+0 -91 reply
21/23drm/i915: rename __hsw_do_{en, dis}able_pc8drivers/gpu/drm/i915/i915_drv.c drivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_drv.h+6 -61 reply
22/23drm/i915: update the PC8 and runtime PM documentationdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_display.c+35 -401 reply
23/23drm/i915: init pm.suspended earlierdrivers/gpu/drm/i915/intel_pm.c+1 -21 reply

Reviews trailers per patch

18 of 23 patches have a Reviewed-by or Acked-by.

PatchPaulo ZanoniJesse BarnesImre Deak
1/23R-b T-b
2/23R-b
3/23R-b
4/23R-b
5/23R-b
6/23R-b
7/23
8/23R-b
9/23
10/23R-b
11/23
12/23R-b
13/23R-b
14/23R-b
15/23R-b
16/23
17/23R-b
18/23R-b
19/23R-b
20/23R-b
21/23R-b
22/23
23/23R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/23] Merge PC8 with runtime PM, v2

From: Paulo Zanoni <[email protected]>

Hi

This is the second time I send this series to the mailing list. Please read the first cover letter:
http://lists.freedesktop.org/archives/intel-gfx/2013-December/037721.html

What's new?

Two main differences:
- Added a patch from Chris, which resulted in a change on how we handle

    dev_priv->pc8.gpu_busy later.

- Fixed a bug on the forcewake handling.

There is some discussion if we want to merge this first, or the VLV power wells patches first. Independently of the decision, I think we should try to at least discuss these patches and review what can be reviewed. I really think this series should make it easier to add runtime PM support to other platforms, and I even added BDW and SNB support on top of these patches.

Thanks,
Paulo

Chris Wilson (1):
drm/i915: Accurately track when we mark the hardware as idle/busy

Paulo Zanoni (22):
drm/i915: put runtime PM only at the end of intel_mark_idle drm/i915: put runtime PM only when we actually release force_wake drm/i915: kill dev_priv->pc8.gpu_idle
drm/i915: rename modeset_update_power_wells
drm/i915: get/put runtime PM without holding rps.hw_lock drm/i915: add forcewake functions that don't touch runtime PM drm/i915: extract __hsw_do_{en,dis}able_package_c8 drm/i915: make PC8 be part of runtime PM suspend/resume drm/i915: get/put runtime PM when we get/put a power domain drm/i915: remove dev_priv->pc8.requirements_met drm/i915: get runtime PM references when the GPU is idle/busy drm/i915: kill pc8.disable_count
drm/i915: remove an indirection level on PC8 functions drm/i915: don't get/put PC8 reference on freeze/thaw drm/i915: get/put runtime PM references for GMBUS and DP AUX drm/i915: don't get/put PC8 when getting/putting power wells drm/i915: remove dev_priv->pc8.enabled
drm/i915: move pc8.irqs_disabled to pm.irqs_disabled drm/i915: kill struct i915_package_c8
drm/i915: rename __hsw_do_{en,dis}able_pc8
drm/i915: update the PC8 and runtime PM documentation drm/i915: init pm.suspended earlier

 drivers/gpu/drm/i915/i915_debugfs.c  |  22 ++--
 drivers/gpu/drm/i915/i915_dma.c      |   2 -
 drivers/gpu/drm/i915/i915_drv.c      |  13 ++-
 drivers/gpu/drm/i915/i915_drv.h      |  79 +++++---------
 drivers/gpu/drm/i915/i915_gem.c      |  16 ++-
 drivers/gpu/drm/i915/i915_irq.c      |  58 +++++------
 drivers/gpu/drm/i915/i915_params.c   |  10 --
 drivers/gpu/drm/i915/intel_display.c | 197 ++++++++---------------------------
 drivers/gpu/drm/i915/intel_dp.c      |   4 +-
 drivers/gpu/drm/i915/intel_drv.h     |  11 +-
 drivers/gpu/drm/i915/intel_i2c.c     |   4 +-
 drivers/gpu/drm/i915/intel_pm.c      |  43 ++------
 drivers/gpu/drm/i915/intel_uncore.c  |  54 +++++++++-
 13 files changed, 192 insertions(+), 321 deletions(-)
Signature · 1 line
1.8.5.3