Skip to content

metadump: fixes for obfuscated dumps

Dave Chinner linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3metadump: contiguous metadata object need to be splitdb/metadump.c+24 -221 reply
2/3metadump: Only verify obfuscated metadata being dumpeddb/io.h db/metadump.c+49 -131 reply
3/3metadump: pathname obfuscation overruns symlink bufferdb/metadump.c+13 -42 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchEric Sandeen
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] metadump: fixes for obfuscated dumps

Hi folks,

The single patch to fix verifier failures in metadata dump has grown. I identified a problem with processing of multiple objects in a single buffer which prevented crcs from being calculated correctly on obfuscated buffers. The first patch fixes that.

The second patch is the 3rd version ofteh original patch. If fixes the problems that Eric pointed out, and it does the correct thing w.r.t to contiguous blocks of single objects as well as inodes with local format data.

The third patch is a fix for a problem that I came across in testing. fsstress left a symlink that consumed the entire inode literal area and so exposed a bug in the path name obfuscation where it failed to correctly recognise the end of the symlink. We don't store symlinks in null terminated form, so the use of strlen to calculate the length of the last componenet was a timebomb waiting to go off...

Cheers,

Dave.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs