v4l: ti-vpe: Some VPE fixes and enhancements
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest14 patches 4 repliesIn review
- v314 patches 18 repliesSuperseded
- v27 patches 11 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 7 patches | 9 replies | Superseded |
Changes in v4 from the cover letter
- More legible code for selection API
- Stricter checking for target type vs crop type in g_selection
- Minor fix in patch 13/14, there was a logical bug in buf_prepare when checking validity of top and bottom fields.
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | v4l: ti-vpe: Make sure in job_ready that we have the needed number of dst_bufsdrivers/ | +3 | 1 reply | |
| 2/14 | v4l: ti-vpe: register video device only when firmware is loadeddrivers/ drivers/ drivers/ | +41 | 0 replies | |
| 3/14 | v4l: ti-vpe: Use video_device_release_emptydrivers/ | +1 | 0 replies | |
| 4/14 | v4l: ti-vpe: Allow DMABUF buffer type supportdrivers/ | +2 | 0 replies | |
| 5/14 | v4l: ti-vpe: Allow usage of smaller imagesdrivers/ | +2 | 0 replies | |
| 6/14 | v4l: ti-vpe: Fix some params in VPE data descriptorsdrivers/ drivers/ drivers/ | +64 | 1 reply | |
| 7/14 | v4l: ti-vpe: Add selection API in VPE driverdrivers/ | +150 | 0 replies | |
| 8/14 | v4l: ti-vpe: Rename csc memory resource namedrivers/ | +1 | 2 replies | |
| 9/14 | v4l: ti-vpe: report correct capabilities in querycapdrivers/ | +1 | 0 replies | |
| 10/14 | v4l: ti-vpe: Use correct bus_info name for the device in querycapdrivers/ | +2 | 0 replies | |
| 11/14 | v4l: ti-vpe: Fix initial configuration queue datadrivers/ | +4 | 0 replies | |
| 12/14 | v4l: ti-vpe: zero out reserved fields in try_fmtdrivers/ | +3 | 0 replies | |
| 13/14 | v4l: ti-vpe: Set correct field parameter for output and capture buffersdrivers/ | +12 | 0 replies | |
| 14/14 | v4l: ti-vpe: retain v4l2_buffer flags for captured buffersdrivers/ | +4 | 0 replies |
Reviews trailers per patch
10 of 14 patches have a Reviewed-by or Acked-by.
| Patch | Hans Verkuil | Kamil Debski |
|---|---|---|
| 1/14 | A-b | |
| 2/14 | ||
| 3/14 | R-b | |
| 4/14 | R-b | |
| 5/14 | R-b | |
| 6/14 | A-b | |
| 7/14 | ||
| 8/14 | ||
| 9/14 | R-b | |
| 10/14 | R-b | |
| 11/14 | R-b | |
| 12/14 | R-b | |
| 13/14 | ||
| 14/14 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 00/14] v4l: ti-vpe: Some VPE fixes and enhancements
This patch set mainly consists of minor fixes for the VPE driver. These fixes ensure the following:
- The VPE module can be inserted and removed successively.
- Make sure that smaller resolutions like qcif work correctly.
- Prevent race condition between firmware loading and an open call to the v4l2 device.
- Prevent the possibility of output m2m queue not having sufficient 'ready' buffers.
- Some VPDMA data descriptor fields weren't understood correctly before. They are now used correctly.
The rest of the patches add some minor features like DMA buf support and cropping/composing.
Reference branch:
[email protected]:boddob/linux.git vpe_for_315
Changes in v4:
- More legible code for selection API
- Stricter checking for target type vs crop type in g_selection
- Minor fix in patch 13/14, there was a logical bug in buf_prepare when checking validity of top and bottom fields.
Changes in v3:
- improvements in selection API patch.
- querycap fixes for v4l2 compliance.
- v4l2_buffer 'field' and flags' fixes for compliance.
- fixes in try_fmt vpe_open for compliance.
- rename a IOMEM resource for better DT compatibility.
Changes in v2:
- selection API used instead of older cropping API.
- Typo fix.
- Some changes in patch 6/7 to support composing on the capture side of VPE.
Archit Taneja (14):
v4l: ti-vpe: Make sure in job_ready that we have the needed number of
dst_bufs
v4l: ti-vpe: register video device only when firmware is loaded
v4l: ti-vpe: Use video_device_release_empty
v4l: ti-vpe: Allow DMABUF buffer type support
v4l: ti-vpe: Allow usage of smaller images
v4l: ti-vpe: Fix some params in VPE data descriptors
v4l: ti-vpe: Add selection API in VPE driver
v4l: ti-vpe: Rename csc memory resource name
v4l: ti-vpe: report correct capabilities in querycap
v4l: ti-vpe: Use correct bus_info name for the device in querycap
v4l: ti-vpe: Fix initial configuration queue data
v4l: ti-vpe: zero out reserved fields in try_fmt
v4l: ti-vpe: Set correct field parameter for output and capture
buffers
v4l: ti-vpe: retain v4l2_buffer flags for captured buffers
drivers/media/platform/ti-vpe/csc.c | 2 +- drivers/media/platform/ti-vpe/vpdma.c | 68 ++++++--- drivers/media/platform/ti-vpe/vpdma.h | 17 ++- drivers/media/platform/ti-vpe/vpe.c | 272 ++++++++++++++++++++++++++++------ 4 files changed, 290 insertions(+), 69 deletions(-)
Signature · 1 line
1.8.3.2