Skip to content

xfsprogs: initial EFSBADCRC support

Dave Chinner linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13libxfs: be more forgiving of a v4 secondary sb w/ junk in v5 fieldslibxfs/xfs_sb.c+11 -20 replies
2/13libxfs: sanitize sb_inopblock in xfs_mount_validate_sblibxfs/xfs_sb.c+1 -00 replies
3/13libxfs: xfs_sb_read_verify() doesn't flag bad crcs on primary sblibxfs/xfs_sb.c+1 -10 replies
4/13libxfs: skip verification on initial "guess" superblock readlibxfs/xfs_sb.c+1 -20 replies
5/13libxfs: limit superblock corruption errors to actual corruptionlibxfs/xfs_sb.c+2 -30 replies
6/13libxfs: skip pointless CRC updates after verifier failureslibxfs/xfs_alloc_btree.c libxfs/xfs_ialloc_btree.c+2 -00 replies
7/13libxfs: Use defines for CRC offsets in all casesinclude/xfs_ag.h include/xfs_dinode.h include/xfs_format.h +6 more+24 -170 replies
8/13libxfs: add helper for verifying checksums on xfs_bufsinclude/libxfs.h libxfs/xfs_alloc.c libxfs/xfs_attr_leaf.c +9 more+23 -260 replies
9/13libxfs: add helper for updating checksums on xfs_bufsinclude/libxfs.h libxfs/xfs_alloc.c libxfs/xfs_attr_leaf.c +9 more+20 -150 replies
10/13libxfs: add xfs_verifier_error()include/darwin.h include/freebsd.h include/gnukfreebsd.h +4 more+20 -00 replies
11/13libxfs: modify verifiers to differentiate CRC from other errorsinclude/libxfs.h libxfs/xfs_alloc.c libxfs/xfs_alloc_btree.c +14 more+126 -1180 replies
12/13xfs_db: Use EFSBADCRC for CRC validity indicationdb/io.c db/io.h+4 -31 reply
13/13repair: phase 1 does not handle superblock CRCsrepair/agheader.c repair/globals.h repair/phase1.c +3 more+62 -482 replies

Reviews trailers per patch

2 of 13 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEric SandeenBrian Foster
SeriesR-b
1/13
2/13
3/13
4/13
5/13
6/13
7/13
8/13
9/13
10/13
11/13
12/13R-b
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/13] xfsprogs: initial EFSBADCRC support

Hi Folks,

This series is a userspace port of Eric's EFSBADCRC verifier error discrimination patch set. It brings across all the relevant pathes form the kernel code and shoe-horns them into the libxfs codebase. There are two extra patches on the end of the series - one to make xfs_db use EFSBADCRC for it's CRC validity indication, and the other to make xfs_repair detect and handle primary superblock CRC failures and recalculation when the primary superblock is rebuilt and rewritten.

This is the first step in bring full awareness of CRC errors into xfs_repair. More patches will follow as I make more repair code aware that EFSBADCRC means that the object that was just read needs repair.

Cheers,

Dave.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs