Allow a client chardev to reconnect if disconnected
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | qemu-char: Allocate CharDriverState in qemu_chr_new_from_optsbackends/ backends/ hw/ +7 more | +122 | 0 replies | |
| 2/7 | qemu-char: Allow a chardev to reconnect if disconnectedinclude/ qemu-char.c qemu-options.hx | +173 | 6 replies | |
| 3/7 | qemu-char: Wait until socket connect to report connectedqemu-char.c | +40 | 0 replies | |
| 4/7 | qemu-char: remove free of chr from win_stdio_closeqemu-char.c | +0 | 0 replies | |
| 5/7 | qemu-char: Close fd at end of fileqemu-char.c | +29 | 0 replies | |
| 6/7 | qemu-char: Clean up error handling in qmp_chardev_addbackends/ backends/ hw/ +7 more | +190 | 0 replies | |
| 7/7 | console: Don't use the console if NULLui/ | +6 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Qemu-devel] [PATCH 0/7] Allow a client chardev to reconnect if disconnected
This patch set was part of the IPMI patches, but people have asked it to be separated out because it's useful by itself and the IPMI patches are stuck in legal limbo.
I have left the patch to move allocating CharDriverState in one place (patch 1). I didn't get much opinion either way, but I think it is an improvement and a net reduction in code. I also added a patch (patch 6) that goes another step there, it makes the error handling in qmp_chardev_add() consistent and is also a net reduction in code.
The main patches to add the feature are patch 2 and patch 3.
The rest are little possible bug fixes that I noticed while working in the code.
I went through all the comments and I believe I fixed everything.
Thanks to everyone that reviewed this before.