Skip to content

ILK+ interrupt improvements, v2

Paulo Zanoni intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 29 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20drm/i915: add GEN5_IRQ_INIT macrodrivers/gpu/drm/i915/i915_irq.c+10 -140 replies
2/20drm/i915: also use GEN5_IRQ_INIT with south display interruptsdrivers/gpu/drm/i915/i915_irq.c+1 -20 replies
3/20drm/i915: use GEN8_IRQ_INIT on GEN5drivers/gpu/drm/i915/i915_irq.c+23 -265 replies
4/20drm/i915: add GEN5_IRQ_FINIdrivers/gpu/drm/i915/i915_irq.c+8 -90 replies
5/20drm/i915: don't forget to uninstall the PM IRQsdrivers/gpu/drm/i915/i915_irq.c+2 -01 reply
6/20drm/i915: properly clear IIR at irq_uninstall on Gen5+drivers/gpu/drm/i915/i915_irq.c+28 -482 replies
7/20drm/i915: add GEN5_IRQ_INITdrivers/gpu/drm/i915/i915_irq.c+18 -151 reply
8/20drm/i915: check if IIR is still zero at postinstall on Gen5+drivers/gpu/drm/i915/i915_irq.c+15 -174 replies
9/20drm/i915: fix SERR_INT init/reset codedrivers/gpu/drm/i915/i915_irq.c+6 -21 reply
10/20drm/i915: fix GEN7_ERR_INT init/reset codedrivers/gpu/drm/i915/i915_irq.c+5 -21 reply
11/20drm/i915: fix open coded gen5_gt_irq_preinstalldrivers/gpu/drm/i915/i915_irq.c+4 -70 replies
12/20drm/i915: extract ibx_irq_uninstalldrivers/gpu/drm/i915/i915_irq.c+14 -70 replies
13/20drm/i915: call ibx_irq_uninstall from gen8_irq_uninstalldrivers/gpu/drm/i915/i915_irq.c+2 -00 replies
14/20drm/i915: enable SDEIER laterdrivers/gpu/drm/i915/i915_irq.c+21 -64 replies
15/20drm/i915: remove ibx_irq_uninstalldrivers/gpu/drm/i915/i915_irq.c+5 -180 replies
16/20drm/i915: add missing intel_hpd_irq_uninstalldrivers/gpu/drm/i915/i915_irq.c+2 -01 reply
17/20drm/i915: add ironlake_irq_resetdrivers/gpu/drm/i915/i915_irq.c+12 -110 replies
18/20drm/i915: add gen8_irq_resetdrivers/gpu/drm/i915/i915_irq.c+7 -192 replies
19/20drm/i915: only enable HWSTAM interrupts on postinstall on ILK+drivers/gpu/drm/i915/i915_irq.c+4 -60 replies
20/20drm/i915: add POSTING_READs to the IRQ init/reset macrosdrivers/gpu/drm/i915/i915_irq.c+5 -111 reply

Reviews trailers per patch

5 of 20 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBen Widawsky
SeriesR-b R-b R-b R-b R-b
1/20
2/20
3/20
4/20
5/20R-b
6/20
7/20
8/20
9/20R-b
10/20R-b
11/20
12/20
13/20
14/20
15/20
16/20R-b
17/20
18/20
19/20
20/20R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/20] ILK+ interrupt improvements, v2

From: Paulo Zanoni <[email protected]>

Hi

This is basically a rebase of "[PATCH 00/19] ILK+ interrupt improvements", which was sent to the mailing list on January 22. There are no real differences, except for the last patch, which is new.

Original cover letter:
http://lists.freedesktop.org/archives/intel-gfx/2014-January/038679.html

The idea behind this series is that at some point our runtime PM code will just call our irq_preinstall, irq_postinstall and irq_uninstall functions instead of using dev_priv->pc8.regsave, so I decided to audit, cleanup and add a few WARNs to our code before we do that change. We gotta be in shape if we want to be exposed to runtime!

Thanks,
Paulo

Paulo Zanoni (20):
drm/i915: add GEN5_IRQ_INIT macro
drm/i915: also use GEN5_IRQ_INIT with south display interrupts drm/i915: use GEN8_IRQ_INIT on GEN5
drm/i915: add GEN5_IRQ_FINI
drm/i915: don't forget to uninstall the PM IRQs drm/i915: properly clear IIR at irq_uninstall on Gen5+ drm/i915: add GEN5_IRQ_INIT
drm/i915: check if IIR is still zero at postinstall on Gen5+ drm/i915: fix SERR_INT init/reset code
drm/i915: fix GEN7_ERR_INT init/reset code
drm/i915: fix open coded gen5_gt_irq_preinstall drm/i915: extract ibx_irq_uninstall
drm/i915: call ibx_irq_uninstall from gen8_irq_uninstall drm/i915: enable SDEIER later
drm/i915: remove ibx_irq_uninstall
drm/i915: add missing intel_hpd_irq_uninstall drm/i915: add ironlake_irq_reset
drm/i915: add gen8_irq_reset
drm/i915: only enable HWSTAM interrupts on postinstall on ILK+ drm/i915: add POSTING_READs to the IRQ init/reset macros

 drivers/gpu/drm/i915/i915_irq.c | 270 ++++++++++++++++++----------------------
 1 file changed, 121 insertions(+), 149 deletions(-)
Signature · 1 line
1.8.5.3