Skip to content

SNB/BDW runtime PM

Paulo Zanoni intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/i915: kill dev_priv->pm.regsavedrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_irq.c drivers/gpu/drm/i915/intel_display.c +1 more+15 -842 replies
2/6drm/i915: add gen-specific runtime suspend/resume functionsdrivers/gpu/drm/i915/i915_drv.c+24 -81 reply
3/6drm/i915: add SNB runtime PM supportdrivers/gpu/drm/i915/i915_drv.c drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_display.c+33 -32 replies
4/6drm/i915: remove HAS_PC8 checkdrivers/gpu/drm/i915/i915_drv.c drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_display.c+2 -131 reply
5/6drm/i915: BDW needs D_COMP writes through MCHBARdrivers/gpu/drm/i915/intel_display.c+18 -101 reply
6/6drm/i915: add BDW runtime PM supportdrivers/gpu/drm/i915/i915_drv.c drivers/gpu/drm/i915/i915_drv.h+8 -32 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchImre Deak
1/6R-b
2/6R-b
3/6
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] SNB/BDW runtime PM

From: Paulo Zanoni <[email protected]>

Hi

This series depends on:
- [PATCH 0/6] More runtime PM fixes
- [PATCH 00/16] Merge PC8 with runtime PM, v3
- [PATCH 00/20] ILK+ interrupt improvements, v2

Patches 1 and 2 are the last pieces of my runtime PM rework, and patch 1 needs all the previous patches to be merged before it can be merged.

Patch 3 adds runtime PM support to SNB. It's not widely tested and I haven't tested it for a while, but at some point this was all that was needed to make my SNB laptop work.

Patches 4-6 are the BDW bits, but I also haven't tested them since the last rebase, and there's the possibility that something is still missing. I wouldn't recommend applying this to production trees yet, but I would recommend you to apply, test the patches and report the results to me!

More importantly, the basic reason why I sent this series to the list is that if someone wants to add runtime PM support to some other platform (BYT anyone?), they should really try to base their patches on top of these. And they should really look at the SNB patch to have some idea on what they need to do first.

Q: Why don't we have IVB runtime PM support?
A: Just because it was easier for me to do development and test on a SNB machine. I really expect that IVB runtime PM will just reuse the SNB bits. The only thing missing for IVB is probably just a few "IS_IVYBRIDGE()" calls, and a call to modeset_update_crtc_power_domains(). I can provide a patch for this later.

Thanks,
Paulo

Paulo Zanoni (6):
drm/i915: kill dev_priv->pm.regsave
drm/i915: add gen-specific runtime suspend/resume functions drm/i915: add SNB runtime PM support
drm/i915: remove HAS_PC8 check
drm/i915: BDW needs D_COMP writes through MCHBAR drm/i915: add BDW runtime PM support

 drivers/gpu/drm/i915/i915_drv.c      | 53 ++++++++++++++++++++----
 drivers/gpu/drm/i915/i915_drv.h      | 16 ++------
 drivers/gpu/drm/i915/i915_irq.c      | 79 +++++-------------------------------
 drivers/gpu/drm/i915/intel_display.c | 43 ++++++++++++--------
 drivers/gpu/drm/i915/intel_drv.h     |  4 +-
 5 files changed, 87 insertions(+), 108 deletions(-)
Signature · 1 line
1.8.5.3